1674329 - Detect replacement of browsing context for cross-group navigations

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now we detect remoteness changes when the framescript (listener.js) gets attached:

https://searchfox.org/mozilla-central/rev/d866b96d74ec2a63f09ee418f048d23f4fd379a2/testing/marionette/listener.js#1088-1090

https://searchfox.org/mozilla-central/rev/d866b96d74ec2a63f09ee418f048d23f4fd379a2/testing/marionette/driver.js#3646-3664

But once we no longer have the framescript registered, we need a new method in figuring out when the current browsing context gets swapped.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As given by Olli swapping browsing contexts should actually only happen for top-level browsing contexts. So we could use browsingContext.browserId to check if the newly created browsing context is related to the currently selected tab.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking marionette-fission-mvp bugs for Fission Beta milestone (M7).

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Here actually some details about which objects are placed by a navigation:
https://firefox-source-docs.mozilla.org/dom/navigation/nav_replace.html

So cross-group navigations can actually trigger a replacement of the browsing context .

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Also important to note here is that a navigation can be triggered at any time by any command or the website itself. As such this detection should run globally and be active all the time, and not only during a navigation command.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I filed bug 1676709 to get a browsing-context-attached notification added, which can be used to check if the browsing context was replaced by comparing the browserId.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1674329 - [marionette] Detect replacement of browsing context for cross-group navigations.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a6a7555c8a5
[marionette] Detect replacement of browsing context for cross-group navigations. r=marionette-reviewers,maja_zf

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4a6a7555c8a5