1678493 - Restrict SwCompositor compositing to the dirty rect

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Matt Woodrow (:mattwoodrow)]

SwCompositor currently composites the entire area of the framebuffer every frame, regardless of what dirty rect was provided.

We should clip drawing to the dirty area, and do less work.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1678493 - Intersect the dirty rect with the compositor surface clip rect in SwCompositor. r?lsalzman

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1678493 - Don't support having both a native gl context and a native compositor in SwCompositor. r?lsalzman

This combination is never used, and adds complexity to support.

Depends on D97705

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1678493 - Pass the SwCompositor clip rect into the inner Composite code rather than intersecting if beforehand. r?lsalzman

The composite code uses the size of the dest rect to determine scaling, and we don't want this to be affected by the clip.

Depends on D97706

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1678493 - Use the clipped dest area when computing bands so that they're evenly spread across the pixels actually drawn. r?lsalzman

Depends on D97707

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94e770a1e904
Intersect the dirty rect with the compositor surface clip rect in SwCompositor. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/9cec7f7add10
Don't support having both a native gl context and a native compositor in SwCompositor. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/f8a0ebaa5e8f
Pass the SwCompositor clip rect into the inner Composite code rather than intersecting if beforehand. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/b7aedb850662
Use the clipped dest area when computing bands so that they're evenly spread across the pixels actually drawn. r=lsalzman

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2792eb7eef84
lint fix on composite.h CLOSED TREE

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/94e770a1e904
https://hg.mozilla.org/mozilla-central/rev/9cec7f7add10
https://hg.mozilla.org/mozilla-central/rev/f8a0ebaa5e8f
https://hg.mozilla.org/mozilla-central/rev/b7aedb850662
https://hg.mozilla.org/mozilla-central/rev/2792eb7eef84