1679215 - sw-wr: Wayland: Sections of the main menu disappear

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Darkspirit]

Attachment: Bildschirmvideo von 24.11.2020 23:02:45.webm

Gnome Wayland, Debian Testing, Intel HD Graphics 630 (KBL GT2)

Screencast: MOZ_ENABLE_WAYLAND=1 mozregression --launch 2020-11-24 --pref gfx.webrender.all:true gfx.webrender.software:true -a about:support

MOZ_ENABLE_WAYLAND=1 mozregression --good 2020-11-01 --bad 2020-11-24 --pref gfx.webrender.all:true gfx.webrender.software:true -a about:support

10:59.46 INFO: Last good revision: 58c3a2573804f12b8798c25605f7b7f01d720350
10:59.46 INFO: First bad revision: b7aedb850662ce676d7408acd4770cb2958143e1
10:59.46 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=58c3a2573804f12b8798c25605f7b7f01d720350&tochange=b7aedb850662ce676d7408acd4770cb2958143e1

b7aedb850662ce676d7408acd4770cb2958143e1 Matt Woodrow — Bug 1678493 - Use the clipped dest area when computing bands so that they're evenly spread across the pixels actually drawn. r=lsalzman
f8a0ebaa5e8ffd9e5e450f48bddb9ce6568a912a Matt Woodrow — Bug 1678493 - Pass the SwCompositor clip rect into the inner Composite code rather than intersecting if beforehand. r=lsalzman
9cec7f7add10d3aa0ce3fb61bc855a0721a85434 Matt Woodrow — Bug 1678493 - Don't support having both a native gl context and a native compositor in SwCompositor. r=lsalzman
94e770a1e9040144c40136388c2defc372ba7a88 Matt Woodrow — Bug 1678493 - Intersect the dirty rect with the compositor surface clip rect in SwCompositor. r=lsalzman

Not reproducible with Xwayland:
mozregression --launch 2020-11-24 --pref gfx.webrender.all:true gfx.webrender.software:true -a about:support

(Xwayland/X11 is already affected by bug 1674473.)

Comment 1

[Darkspirit]

Not fixed by bug 1678954 comment 6:
MOZ_ENABLE_WAYLAND=1 mozregression --repo autoland --launch 34aba2d9485ff3f38b9c5b3fa8a52c73180649dc --pref gfx.webrender.all:true gfx.webrender.software:true -a about:support

Comment 2

[Lee Salzman [:lsalzman]]

So this was not fixed by bug 1678954, but still appears to be a regression from bug 1678493?

Comment 3

[Kestrel]

I can confirm this is still reproducible on latest Nightly and it did not occur before Bug 1678493.

Comment 4

[Darkspirit]

Yes, it seems so.

Comment 5

[Matt Woodrow (:mattwoodrow)]

Martin, I suspect this is an issue in the wayland widget code, since it only affects that configuration.

My initial guess is that we're copying pixels outside of the dirty rects that were drawn.

Could you take a look please?

Comment 6

[Martin Stránský [:stransky] (ni? me)]

This is related to Bug 1674473. When transparent popup is drawn by basic compositor, Wayland SW backend contains a hack for Bug 1674473 and clears widget backend. The hack apparently works poorly and clears the background even when partial popup update is performed.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

I expect the bug here is caused by WebRender - Bug 1678493. Although whole surface is locked for drawing, only partial surface area is updated. Wayland "redraw" detector thinks it's a complete popup redraw so underlying memory is cleared. A possible solutions may be:

• don't draw transparent objects to wayland surfaces with blending. I'm not sure it's possible, if the blending is used for popup compositing or so.
• use intermediate image cache for popups. That's what X11 does.
• update webredner to lock only a part of the surface which is going to be updated.

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - Fisable partial present

When partial present was disabled, I did not see the problem.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

This bug is caused by different LayoutDeviceIntRegion& aInvalidRegion sizes passed to StartRemoteDrawingInRegion() and EndRemoteDrawingInRegion().

When StartRemoteDrawingInRegion() (issued from RenderCompositorSWGL::BeginFrame) obtains rect of whole window, it assumes that whole window is going to be repainted and we can do some optimizations here like switch wayland buffers and so on.

Lee, is it possible for webrender to pass the same sizes to both StartRemoteDrawingInRegion() and EndRemoteDrawingInRegion()?

Comment 10

[Lee Salzman [:lsalzman]]

Attachment: Bug 1679215 - add support for StartCompositing hook to RenderCompositor. r?mattwoodrow

We need to be able to delay instantiation of the drawing region until after we have the
dirty rects from start_compositing. This was currently not routed to RenderCompositor,
which is required to do this. Further, SwCompositor needs to always keep track of the
RenderCompositor that it is associated with regardless of whether or not it is a native
compositor so that this hook can be properly engaged.

Comment 11

[Lee Salzman [:lsalzman]]

Attachment: Bug 1679215 - limit SWGL compositing to dirty region. r?mattwoodrow

Depends on D100974

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1cbff508b18
add support for StartCompositing hook to RenderCompositor. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/c98b81eac062
limit SWGL compositing to dirty region. r=mattwoodrow

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c1cbff508b18
https://hg.mozilla.org/mozilla-central/rev/c98b81eac062

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Filed Bug 1686209 as a possible regression on Wayland (may be also a bug in Wayland backend).

Comment 16

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #28386 (as of Tue, 12 Jan 2021 15:31:03 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
10%	tp5o_scroll		linux64-shippable-qr	e10s stylo webrender-sw	3.15 -> 2.84

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28386