1678611 - Replace onTitleChanged with a page-title-changed PlacesEvent

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Marco Bonardo [:mak]]

In the future it would be great if the title of a page could only be changed by adding a visit (and then page-visited would be enough for it), but for now the DocShell is sending separate notifications for visit addition and title change.
Thus temporarily we can introduce a page-title-changed event, so we can remove onTitleChanged.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1678611: Implement a mechanism to fire page-title-changed event.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1678611: Apply page-title-changed event instead of onTitleChanged.

Depends on D98278

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1678611: Remove onTitleChanged interface from nsINavHistoryService.

Depends on D98280

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1678611: Add a test for multi observation.

Depends on D98281

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/537d90684581
Implement a mechanism to fire page-title-changed event. r=mak
https://hg.mozilla.org/integration/autoland/rev/942167393237
Apply page-title-changed event instead of onTitleChanged. r=mak,mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/6498a49aab45
Remove onTitleChanged interface from nsINavHistoryService. r=mak,mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/01e15bba25d4
Add a test for multi observation. r=mak

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/537d90684581
https://hg.mozilla.org/mozilla-central/rev/942167393237
https://hg.mozilla.org/mozilla-central/rev/6498a49aab45
https://hg.mozilla.org/mozilla-central/rev/01e15bba25d4