1756663 - Add test for id parameter in history.onTitleChanged event

Status: RESOLVED FIXED

(WebExtensions :: General, task)

Description

[Rob Wu [:robwu]]

In bug 1678611, as part of a refactor, the history.onTitleChanged unintentionally started to receive an id option, in https://hg.mozilla.org/mozilla-central/rev/942167393237

It makes sense to have this property, so let's add a unit test to verify that it is present.

Adding dev-doc-needed so that this id property can be documented on MDN at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/history/onTitleChanged and possibly also in its browser compat table.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1756663 - Add test for id option of history.onTitleChanged

In bug 1678611, the id property was added to this event, without unit
tests. The existing test didn't pick up the change because it checked
for a specific property. This patch adds a check of the whole event
object to get coverage for the id property AND to avoid this kind of
issue in the future.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d6d35d5f6f7
Add test for id option of history.onTitleChanged r=willdurand

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2d6d35d5f6f7

Comment 4

[Richard Bloor]

Doc change made in https://github.com/mdn/content/pull/17386 and https://github.com/mdn/browser-compat-data/pull/16715