1678636 - When pausing during load, paused overlay is shown _after_ resuming

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

STR:

1. Open a tab with data:text/html,<meta charset=utf8><script>debugger;</script>Hello
2. Open DevTools
3. Reload

The debugger statement is hit, the debugger pauses but the page overlay is not displayed (which is Bug 1580394).
Worse, when resuming, the overlay does appear, although the debugger isn't paused anymore and clicking on any buttons does not hide it

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1678636 - [devtools] Prevent paused overlay to be shown after resuming. r=ladybenko.

Before showing the pause overlay, we wait for the page to be fully loaded.
This introduced some delay, and at the moment we were showing the overlay, the
debugger could not be paused anymore.
This patch adds another check to ensure the debugger is paused, as well as a
test to avoid regression."

Depends on D97777

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f29982da3440
[devtools] Prevent paused overlay to be shown after resuming. r=ladybenko.

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f29982da3440

Comment 4

[Florin Strugariu [:Bebe]]

== Change summary for alert #27927 (as of Thu, 03 Dec 2020 05:24:41 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
7%	Heap Unclassified		windows10-64-shippable-qr		50,750,170.04 -> 47,224,184.74
6%	Heap Unclassified		linux1804-64-shippable-qr		252,988,877.95 -> 237,740,048.25
3%	Explicit Memory		linux1804-64-shippable-qr		513,823,410.94 -> 498,851,067.48

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27927