Closed
Bug 167867
Opened 22 years ago
Closed 22 years ago
unicodeToEntity should use regexps
Categories
(Other Applications :: DOM Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: caillon, Assigned: caillon)
References
Details
(Keywords: perf)
Attachments
(1 file, 1 obsolete file)
|
5.17 KB,
patch
|
timeless
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Timeless pointed out that we could use JS regexps to make the code in
viewPartialSource.js and dom.js more performant.
|
Assignee | |
Comment 1•22 years ago
|
||
I couldn't figure out how to trigger the code in viewPartialSource.js -- it
seems it only gets triggered for mathML bits, but I was unable even then to get
it to be called successfully so I couldn't test it there. That
notwithstanding, this should do the trick since it works great in Inspector.
|
|
Assignee | |
Comment 2•22 years ago
|
||
Attachment #99114 -
Attachment is obsolete: true
Attachment #99823 -
Flags: review+
|
||
Comment 4•22 years ago
|
||
Comment on attachment 99823 [details] [diff] [review]
More robust regexp
sr=bzbarsky; maybe it's time for a util file of some sort? ;)
(oh and that use of function in a regexp is _sweet_! I never knew you could do
that).
Attachment #99823 -
Flags: superreview+
|
|
Assignee | |
Comment 5•22 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Core → Other Applications
|
||
Updated•18 years ago
|
QA Contact: timeless → dom-inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•