167867 - unicodeToEntity should use regexps

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Timeless pointed out that we could use JS regexps to make the code in
viewPartialSource.js and dom.js more performant.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Something like this

I couldn't figure out how to trigger the code in viewPartialSource.js -- it
seems it only gets triggered for mathML bits, but I was unable even then to get
it to be called successfully so I couldn't test it there.  That
notwithstanding, this should do the trick since it works great in Inspector.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: More robust regexp

Comment 3

[timeless]

filed bug 172302 about unifying the two impls

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 99823 [details] [diff] [review]
More robust regexp

sr=bzbarsky; maybe it's time for a util file of some sort?  ;)

(oh and that use of function in a regexp is _sweet_!  I never knew you could do
that).

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in.