Status

--
enhancement
ASSIGNED
16 years ago
7 years ago

People

(Reporter: timeless, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
view partial source and dom inspector have very similar functions which could be
unified. We should consider doing this, but we don't have to do it today :).
(Reporter)

Updated

16 years ago
Depends on: 167867
Mass re-assigning bugs to dom.inspector@extensions.bugs
Assignee: caillon → dom.inspector
Product: Core → Other Applications
We can use this in everything becuase it is part of toolkit, right?  My only concern is Seamonkey.

http://lxr.mozilla.org/seamonkey/source/toolkit/components/viewsource/content/viewPartialSource.js#467
OS: Windows 2000 → All
Hardware: PC → All
There are parts of toolkit that are actually toolkit and parts that are not, apparently.  Talk to a toolkit peer about what parts of toolkit are guaranteed to be present in all XULRunner apps, then if this is one of those parts talk to the seamonkey UI folks to make sure it gets built in Seamonkey.
(In reply to comment #3)
> There are parts of toolkit that are actually toolkit and parts that are not,
> apparently.  Talk to a toolkit peer about what parts of toolkit are guaranteed
> to be present in all XULRunner apps, then if this is one of those parts talk to
> the seamonkey UI folks to make sure it gets built in Seamonkey.

<gavin>	its apparently enabled for everything but MOZ_EMBEDDING_PROFILE=(basic|minimal)

So, we are good to use that code then, correct?
We would be if everything were a XULRunner app... sadly, I doubt it is -- for example I just don't see the relevant files in a Seamonkey objdir (something you could have checked on yourself, btw).
Assignee: dom-inspector → nobody
QA Contact: timeless → dom-inspector
Created attachment 536817 [details] [diff] [review]
Use unicodeTOentity from viewPartialSource; remove associated now-dead code (including _toXML)
Assignee: nobody → Sevenspade
Status: NEW → ASSIGNED
Attachment #536817 - Flags: review?(neil)

Comment 7

7 years ago
Comment on attachment 536817 [details] [diff] [review]
Use unicodeTOentity from viewPartialSource; remove associated now-dead code (including _toXML)

I don't think viewPartialSource's unicodeTOentity is suitable as it includes HTML markup to highlight the entity.

Interestingly I notice that the XML serialiser only encodes the basic entities.
Attachment #536817 - Flags: review?(neil) → review-
Assignee: Sevenspade → nobody
You need to log in before you can comment on or make changes to this bug.