1678951 - When launching Nightly or opening new windows, toolbar buttons placed on the bookmarks toolbar flicker to the side in the time that takes to load the bookmark items

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Itiel]

STR:

1. Windows 10, latest Nightly
2. Enable the bookmarks toolbar, place some bookmarks there
3. Also add a toolbar button item there, e.g. the bookmarks menu button
4. Restart Nightly / open new windows

AR:
The bookmarks take time to appear, and in that time the bookmarks menu button appear somewhat in the middle of the bookmarks toolbar, then shifts back to its place.

ER:
No flicker.

Comment 1

[Itiel]

Attachment: Screencast.gif

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1667237

Comment 3

[:Gijs (he/him)]

I think the patch in bug 1678921 fixes this.

Comment 4

[:Gijs (he/him)]

Itiel, can you confirm this is fixed for you on today's nightly? Thank you!

Comment 5

[Itiel]

By "fixed", are you referring only to the toolbar buttons not flickering anymore?
Well, sort of. The toolbar button is stuck in its place more or less, but there is a slight flicker of 1-2px. I think this was the case even before the regression, so I'd say it's fixed.

As for the bookmarks taking time to appear, not fixed (and I guess this will be WONTFIXed as they all appear together instead of one at a time).

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

:gijs can we mark this as fixed and file a separate bug for the performance regression?

Comment 7

[:Gijs (he/him)]

(In reply to Dave Hunt [:davehunt] [he/him] ⌚GMT from comment #6)

:gijs can we mark this as fixed and file a separate bug for the performance regression?

We can mark this as fixed, but I think there's 2 issues left:

(In reply to Itiel from comment #5)

By "fixed", are you referring only to the toolbar buttons not flickering anymore?
Well, sort of. The toolbar button is stuck in its place more or less, but there is a slight flicker of 1-2px. I think this was the case even before the regression, so I'd say it's fixed.

Is it possible for you to file a new bug, ideally with a screen recording to indicate what you mean?

As for the bookmarks taking time to appear, not fixed (and I guess this will be WONTFIXed as they all appear together instead of one at a time).

I think on startup, the bookmarks appearing a little later than before won't be fixed as we've deliberately changed the order here.

However, I think there's probably work we can do here to improve the behaviour for new windows, and a new bug would be useful for that, too. I filed bug 1681138 for this.

Comment 8

[Itiel]

Filed as bug 1681169.