1681169 - 1-2px flicker with toolbarbuttons placed on the bookmarks toolbar when opening a new window

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Itiel]

Attachment: Screencast

STR:

1. Enable the bookmarks toolbar, add some bookmarks there
2. Add the Bookmarks Menu toolbarbutton to the bookmarks toolbar
3. Open a new window

AR:
The toolbarbutton flickers 2-3px to the side while loading the bookmarks are loaded.

ER:
No flicker.

Noticed this when I verified bug 1678951.

Comment 1

[:Gijs (he/him)]

This is pretty confusing. Itiel, just to check, am I right in thinking this is an RTL window so the bookmarks menu button that you've put on the bookmarks toolbar is at the logical "start" of the toolbar, and it's switching towards the start (so some padding/margin / element before it in the markup is decreasing / being hidden) ? And is the screencast from win10?

Comment 2

[Itiel]

(In reply to :Gijs (he/him) from comment #1)

This is pretty confusing. Itiel, just to check, am I right in thinking this is an RTL window so the bookmarks menu button that you've put on the bookmarks toolbar is at the logical "start" of the toolbar, and it's switching towards the start (so some padding/margin / element before it in the markup is decreasing / being hidden) ?

Yes, I am on RTL. The same applies on an LTR build, just tested.
And yes, your explanation seems to make sense.

And is the screencast from win10?

Yes.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1681169 - fix few-px horizontal flicker of bookmarks toolbar buttons due to margins on empty toolbar placeholder, r?jaws

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f01f746874d4
fix few-px horizontal flicker of bookmarks toolbar buttons due to margins on empty toolbar placeholder, r=jaws

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f01f746874d4

Comment 6

[:Gijs (he/him)]

The horizontal shift should be gone now, I hope? :-)

Comment 7

[Itiel]

Indeed. Tested when you posted the patch and tested now on Nightly, no shifting.
Thanks!