1679075 - Crash in [@ mozilla::a11y::GeckoTextMarker::ContainerAsHyperTextWrap]

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Crash report: https://crash-stats.mozilla.org/report/index/75f8e66b-f5f7-42d2-b32b-a45a40201123

Reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS

Top 10 frames of crashing thread:

0 XUL mozilla::a11y::GeckoTextMarker::ContainerAsHyperTextWrap const accessible/mac/GeckoTextMarker.h:57
1 XUL mozilla::a11y::GeckoTextMarkerRange::Length const accessible/mac/GeckoTextMarker.mm:401
2 XUL -[mozTextAccessible moxSelectedTextRange] accessible/mac/mozTextAccessible.mm:179
3 XUL -[MOXAccessibleBase accessibilityAttributeValue:] accessible/mac/MOXAccessibleBase.mm:139
4 AppKit NSAccessibilityGetObjectForAttributeUsingLegacyAPI 
5 AppKit ___NSAccessibilityEntryPointValueForAttribute_block_invoke.805 
6 AppKit NSAccessibilityPerformEntryPointObject 
7 AppKit _NSAccessibilityEntryPointValueForAttribute 
8 AppKit -[NSObject _accessibilityValueForAttribute:clientError:] 
9 AppKit CopyAppKitUIElementAttributeValueNoCatch 

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1679075 - Don't go past empty input field in HyperTextIterator::Next. r?morgan!

The normalize function was putting the current container/offset past the end boundary. This caused overruns with getting the text for the range of the input object, and some unexpected invalid ranges.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/582424635640
Don't go past empty input field in HyperTextIterator::Next. r=morgan

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/582424635640

Comment 5

[⚜️Québec🇨🇦Canada🍁]

[@ mozilla::a11y::GeckoTextMarker::ContainerAsHyperTextWrap] - Firefox 85.0 Crash Report - Report ID: a2f2fb61-bcdc-4d33-b8d4-37c650210129

https://crash-stats.mozilla.org/report/index/a2f2fb61-bcdc-4d33-b8d4-37c650210129

Comment 6

[⚜️Québec🇨🇦Canada🍁]

(In reply to Cosmin Sabou [:CosminS] from comment #4)

https://hg.mozilla.org/mozilla-central/rev/582424635640

[@ mozilla::a11y::GeckoTextMarker::ContainerAsHyperTextWrap] - Firefox 85.0 Crash Report - Report ID: a2f2fb61-bcdc-4d33-b8d4-37c650210129

https://crash-stats.mozilla.org/report/index/a2f2fb61-bcdc-4d33-b8d4-37c650210129