Closed Bug 1679117 Opened 4 years ago Closed 2 months ago

[De] shortcuts.xhtml contains Typos

Categories

(SeaMonkey :: Help Documentation, defect, P5)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: RainerBielefeldNG, Assigned: RainerBielefeldNG)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [easyconfirm])

Attachments

(1 file, 1 obsolete file)

Steps how to reproduce with installed unofficial (by wg9s) De SeaMonkey 2.53.6 beta 1 pre Mozilla/5.0 (NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 Build 20201115220004 (Default User Profile, Default Classic Theme) on German WIN7 64bit

  1. Browser → F1
    » Help appears
  2. Type search string "Tastenkombinationen" → Click first hit "Allgemeine Tastenkombinationen"
    » Related Help appears
  3. Check for Typos !

I found:

oderr →
oder (multiple times in text)

or →
oder (multiple times in Text)

Space →
Leertaste (but „Space“ also might be rather common for German users?)

Editiern →
Editieren

nächten →
nächsten

auswälen →
auswählen (multiple times)

Nästes Wort →
Nächstes Wort

Additional Info:

a) Contents: I can't confirm that Ctrl+K brings focus to search field

(In reply to Rainer Bielefeld from comment #0)

Steps how to reproduce with installed unofficial (by wg9s) De SeaMonkey 2.53.6 beta 1 pre Mozilla/5.0 (NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 Build 20201115220004 (Default User Profile, Default Classic Theme) on German WIN7 64bit

  1. Browser → F1
    » Help appears
  2. Type search string "Tastenkombinationen" → Click first hit "Allgemeine Tastenkombinationen"
    » Related Help appears
  3. Check for Typos !

I found:

oderr →
oder (multiple times in text)

or →
oder (multiple times in Text)

Space →
Leertaste (but „Space“ also might be rather common for German users?)

Editiern →
Editieren

nächten →
nächsten

auswälen →
auswählen (multiple times)

Nästes Wort →
Nächstes Wort

Additional Info:

a) Contents: I can't confirm that Ctrl+K brings focus to search field

Hello , I would like to work on this bug. This will be my very first issue, can you please guide me how to follow it to reach the bug.
Thank You.

I sent some hints by PM

Most still REPRODUCIBLE with installation of unofficial (by wg9s) De SeaMonkey 2.53.14 beta 1 pre Mozilla/5.0 (NT 6.1; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0 Build 20220801210005 (Same with normal user Profile and newly created User Profile Default Classic Theme) on German WIN10 64bit

Still unconfirmed, but there is no doubt ...
so I take this one

Assignee: nobody → RainerBielefeldNG
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

oderr →
oder (multiple times in text)
has become fixed in Between. Rest still does exist.

I will add a patch next days

See Also: → 1841670
Attached patch shortcuts_patch.xhtml (obsolete) — Splinter Review

I checked source files : WG9S 2.53.18 is identical with GitLab 2.53.17

My patch!

oderr
oder (multiple times in text)
gone

or →
oder (multiple times in Text)
patched in lines 180,181,182,310

Space →
Leertaste (but „Space“ also might be rather common for German users?)
patched in line 211

Editiern →
Editieren
patched in line 294

nächten →
nächsten
patched in lines 339,

auswälen →
auswählen (multiple times)
patched in lines 381, 387, 393, 399,

Nästes Wort →
Nächstes Wort
patched in lines 435,

Attachment #9353476 - Flags: review?(frgrahl)
Attached patch 1679117.patchSplinter Review

This looks ok to me. Is it ok if I just add it to the global l10n patch for 2.53 and not as a separate one?

Attachment #9353476 - Attachment is obsolete: true
Attachment #9353476 - Flags: review?(frgrahl)
Attachment #9353543 - Flags: review+
Attachment #9353543 - Flags: approval-comm-release+

Forgot to ask for ni

Flags: needinfo?(RainerBielefeldNG)

Please excuse me for late response ...
In the patch I only found a single typo in line 381:

Letztes Zeichen auswäulen →
Letztes Zeichen auswählen →

all the rest seems ok.

Flags: needinfo?(RainerBielefeldNG)

I fixed the one typo mentioned yesterday. Should be in the current 2.53.20 prerelease. The others did go in some time ago.

Nothing left here I think. Our new location for l10n is https://gitlab.com/seamonkey-project/seamonkey-central-l10n so I will update central too soon. Wasn't possible before becuase we couldn't push patches directly into mozillas l10n central repo.

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: