1679425 - Crash in [@ shutdownhang | mozilla::TaskController::GetRunnableForMTTask | nsThread::Shutdown | mozilla::storage::Connection::shutdownAsyncThread]

Status: NEW

(Core :: SQLite and Embedded Database Bindings, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Signature existed before, crash volume seems to have increased with Firefox 83.0 (crash count for previous releases almost reached).

Crash report: https://crash-stats.mozilla.org/report/index/bde44598-bb3b-4293-850e-2451a0201126

MOZ_CRASH Reason: Shutdown hanging at step quit-application. Something is blocking the main-thread.

Top 10 frames of crashing thread:

0 ntdll.dll NtWaitForKeyedEvent 
1 ntdll.dll RtlSleepConditionVariableSRW 
2 kernel32.dll SleepConditionVariableSRW 
3 mozglue.dll mozilla::detail::ConditionVariableImpl::wait mozglue/misc/ConditionVariable_windows.cpp:50
4 xul.dll mozilla::TaskController::GetRunnableForMTTask xpcom/threads/TaskController.cpp:283
5 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1143
6 xul.dll nsThread::Shutdown xpcom/threads/nsThread.cpp:898
7 xul.dll mozilla::storage::Connection::shutdownAsyncThread storage/mozStorageConnection.cpp:1080
8 xul.dll mozilla::detail::RunnableMethodImpl< xpcom/threads/nsThreadUtils.h:1240
9 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:515

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Crash signature existed for 81 and before but not for 82.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Is this a signature change and/or an increase in crash volume?

Comment 3

[Jens Stutte [:jstutte]]

It seems to be the same as shutdownhang | nsThread::Shutdown | mozilla::storage::Connection::shutdownAsyncThread except for being controlled by a task controller sometimes.

Comment 4

[Jens Stutte [:jstutte]]

But very likely signatures will change soon once bug 1672369 landed entirely.

Comment 5

[Simon Giesecke [:sg] [he/him]]

(In reply to Jens Stutte [:jstutte] from comment #4)

But very likely signatures will change soon once bug 1672369 landed entirely.

This isn't the quota manager/client shutdown hang, so I don't think this will have changed with that bug.

Adding two more Windows-specific signatures, which seem to be related.

Apparently, the behaviour in Nightly is differently, since we have almost no reports for Nightly. Maybe there's an assertion failure instead in Nightly?

Comment 6

[Jens Stutte [:jstutte]]

(In reply to Simon Giesecke [:sg] [he/him] from comment #5)

Apparently, the behaviour in Nightly is differently, since we have almost no reports for Nightly. Maybe there's an assertion failure instead in Nightly?

I assume this is due to the fast shutdown being active on nightly, see bug 1606879 and children.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

There's a bunch of underlying consumers of mozStorage all mashed together here (ex: NSS/SSL DataStorage, legacy LocalStorage), but the unifying factor is mozStorage's async thread shutdown call. Moving to Toolkit::Storage. Note that the common cause also does seem to be that code is still actively doing database stuff.

The actionable thing here would be to require all consumers of mozStorage to provide an explicit async shutdown blocker to better attribute errors, but in general it's also a question of doing crash-only shutdown in some cases. (Although not when privacy is involved.)

Comment 8

[Worcester12345]

Just had a couple crashes with "mozilla::TaskController::GetRunnableForMTTask", and started a new bug. Just an FYI.

Comment 9

[Wayne Mery (:wsmwk)]

bp-f1469a5c-4049-401a-bac7-ecd0c0211031 - #33 crash for Thunderbird 91.2.1

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 20 desktop browser crashes on release

:mak, could you consider increasing the severity of this top-crash bug?

For more information, please visit auto_nag documentation.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

For more information, please visit auto_nag documentation.

Comment 12

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk) from comment #9)

bp-f1469a5c-4049-401a-bac7-ecd0c0211031 - #33 crash for Thunderbird 91.2.1

#34 for Thunderbird 102.4.1