1679575 - ssb launched from the command lines doesn't use manifest file

Status: RESOLVED WONTFIX

(Firefox :: General, enhancement)

Description

[Tom Hindle]

Attachment: ssb.manifest.patch

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

firefox --ssb https://www.google.com

(with browse.ssb.enabled in about:config)

Actual results:

ssb window opened with "www.google.com" open in title bar.

Additionally the ssb window/taskbaricon was the firefox icon rather than the google icon.

Expected results:

ssb window opened with "Google Web Homepage" open in title bar.

One solution would be to allow specifying a manifest on the command line

firefox --ssb https://www.google.com --manifest ~/manifest.json

Attaching proof of concept patch for this.

Comment 1

[Tom Hindle]

related issue https://bugzilla.mozilla.org/show_bug.cgi?id=1602168

Comment 2

[Daniel Bodea [:danibodea]]

Opening Firefox ESR v78.5.0esr or Firefox Release v83.0 from Command Prompt with command firefox --ssb https://www.google.com (after already having ssb enabled in the opening profile) does properly open the Site-Specific window (without the top bar). Furthermore, the title bar sais "www.google.com" and has the Google icon.

This being said, I think I cannot reproduce the issue the way you describe it.
I will not confirm it, however, I will set its component as General, considering it's the component related to SSB.
Someone with more understanding of this matter should have a shot.

Comment 3

[Daniel Bodea [:danibodea]]

Can you provide any other information that you might have missed?
Please try to reproduce it in a newly created profile and let us know of the result.
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Multiple_profiles

Comment 4

[Tom Hindle]

(In reply to Bodea Daniel [:danibodea] from comment #2)

Opening Firefox ESR v78.5.0esr or Firefox Release v83.0 from Command Prompt with command firefox --ssb https://www.google.com (after already having ssb enabled in the opening profile) does properly open the Site-Specific window (without the top bar). Furthermore, the title bar sais "www.google.com" and has the Google icon.

This being said, I think I cannot reproduce the issue the way you describe it.
I will not confirm it, however, I will set its component as General, considering it's the component related to SSB.
Someone with more understanding of this matter should have a shot.

If the title bar said "www.google.com" then you have reproduce the issue. It should say "Google Web Homepage". (ie. the title rather than the domain name).

As for the icon, there are some differences per platform - on the Linux I use there is no window icon, but the icon should show in the taskbar.
(maybe that's a different Linux issue so ignoring that for now)

Steps with new profile (on windows using firefox 83.0)

1. "c:\Program Files\Mozilla Firefox\firefox.exe" --ssb www.google.com --profile mynewprofile

• as expected ssb window does not open.

2. about:config
3. set browser.ssb.enabled to true.
4. close browser window.
5. "c:\Program Files\Mozilla Firefox\firefox.exe" --ssb www.google.com --profile mynewprofile

ACTUAL: title bar says www.google.com
EXPECTED: title bar says "Google Web Homepage"

I do see on windows, that the icon is set correctly after a short delay. (flicks from FF icon to google icon)

Comment 5

[Daniel Bodea [:danibodea]]

If the title bar said "www.google.com" then you have reproduced the issue. It should say "Google Web Homepage". (ie. the title rather than the domain name).

Steps with new profile (on windows using firefox 83.0)

1. "c:\Program Files\Mozilla Firefox\firefox.exe" --ssb www.google.com --profile mynewprofile

• as expected ssb window does not open.

2. about:config
3. set browser.ssb.enabled to true.
4. close browser window.
5. "c:\Program Files\Mozilla Firefox\firefox.exe" --ssb www.google.com --profile mynewprofile

ACTUAL: title bar says www.google.com
EXPECTED: title bar says "Google Web Homepage"

I do see on windows, that the icon is set correctly after a short delay. (flicks from FF icon to google icon)

Base on the above, I confirm the behavior described by the reporter, however, I do not know if it's valid or not.
I also confirm the above steps as similar to the ones I used.
I also confirm the behavior of the icon in the bar in Windows 10 (which sure is as intended).

Furthermore, this issue occurs even in the latest ESR v78.5.0esr and the SSB feature could not be activated in Firefox Release v72, so I am assuming this is not a regression.

Comment 6

[Dave Townsend [:mossop]]

Closing per bug 1682593.