1679664 - Outgoing username is lost after clicking "Advanced config" if auth mode is "Autodetect"

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[David Ward]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.66 Safari/537.36

Steps to reproduce:

1. Click "≡" > "New" > "Existing Mail Account..."
2. Enter a name and e-mail address, and click "Configure manually...".
3. Ensure that the outgoing auth mode is "Autodetect" (default), and the outgoing username is not empty (default is e-mail address). Change any other settings as desired, except for those.
4. Click "Advanced config", and then click "OK".
5. Click "Outgoing Server (SMTP)" on the left, and then select the newly-created SMTP server.

Actual results:

The username for the SMTP server is empty.

Expected results:

The username for the SMTP server should be what was entered before clicking "Advanced config".
Compare this behavior to the incoming server: the entered username is transferred even if the auth mode was "Autodetect".

Comment 1

[David Ward]

Attachment: Bug 1679664 - Part 1: Only drop outgoing username/password if auth method is none.

During account creation in manual edit mode, clicking "Advanced config"
creates the backend account without verifying the settings, so these can
be edited further. The entered username/password for the outgoing server
should only be ignored if the auth method is "No authentication".

Comment 2

[David Ward]

Attachment: Bug 1679664 - Part 2: Handle unspecified settings in SMTP server info box.

If "Advanced config" was clicked during account creation, some settings
might not have been selected yet. Let the UI show this accurately.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cb5b72c9428b
Part 1: Only drop outgoing username/password if auth method is none. r=mkmelin
https://hg.mozilla.org/comm-central/rev/5badd91b826d
Part 2: Handle unspecified settings in SMTP server info box. r=mkmelin