1679713 - Error when using alert() in compose window editor

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[C-E]

Attachment: alert-bug.xpi

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

manifest.json:
"compose_action": {
"default_title": "Test",
"default_icon": "test.svg"
},
"permissions": [
"compose",
"activeTab",
"tabs"
]

background.js:
async function klickaktion(tab) {
await browser.tabs.executeScript(tab.id, {
file: "hello.js"
})
}
browser.composeAction.onClicked.addListener(klickaktion);

hello.js:
alert("Hello");

Actual results:

No alert displayed, console shows the error:
TypeError: browser.leaveModalState is not a function PromptParent.jsm:171:17

Expected results:

Alert should be displayed without console error entry.

Comment 1

[Geoff Lankow (:darktrojan)]

Confirming, this happens for anything that calls alert in the message composition editor, that it was found by an extension is irrelevant.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1679713 - Allow composer prompts to open without enterModalState. r=darktrojan

Fixes alert() and related functions when called from the composition
editor. The browser in that case is <editor> which does not support
enterModalState and leaveModalState.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/936db9e29968
Allow composer prompts to open without enterModalState. r=darktrojan

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9203606 [details]
Bug 1679713 - Allow composer prompts to open without enterModalState. r=darktrojan

[Approval Request Comment]
Safe bug fix.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9203606 [details]
Bug 1679713 - Allow composer prompts to open without enterModalState. r=darktrojan

[Triage Comment]
Approved for esr78

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 78.10.2:
https://hg.mozilla.org/releases/comm-esr78/rev/60efe2160ba6