1679728 - `browser.showPersonalToolbar` in distribution.ini no longer works

Status: VERIFIED FIXED

(Firefox :: Distributions, defect)

Description

[Hector Zhao [:hectorz]]

The pref was first introduced in bug 1239949.

A similar Enterprise policy was updated as part of bug 727668's patch 1, but not this one.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 727668

Comment 2

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
May affect enterprise users for the 84 release

Hector, does this impact the China builds?

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1679728 - fix distribution support for browser.showPersonalToolbar, r?mkaply

Comment 4

[Mike Kaply [:mkaply]]

Yes, this affects China. Now that we have a pref for this, though, we could just switch to using the new pref instead of the custom distro pref.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87b6225c435c
fix distribution support for browser.showPersonalToolbar, r=mkaply

Comment 6

[Hector Zhao [:hectorz]]

Hi :Gijs, thanks for the quick fix!

(In reply to Mike Kaply [:mkaply] from comment #4)

Yes, this affects China. Now that we have a pref for this, though, we could just switch to using the new pref instead of the custom distro pref.

I understand this is possible, nevertheless, I wanted to bring this up to clarify whether browser.showPersonalToolbar should be considered supported or obsolete, before making any change to the distribution.ini.

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/87b6225c435c

Comment 8

[:Gijs (he/him)]

Comment on attachment 9190643 [details]
Bug 1679728 - fix distribution support for browser.showPersonalToolbar, r?mkaply

Beta/Release Uplift Approval Request

• User impact if declined: Enterprise default-enabling the bookmarks toolbar wouldn't work
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Use a distribution setup to set browser.showPersonalToolbar pref to true, check that the bookmarks toolbar shows both for the new tab page and for other pages that load
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a relatively small change and only affects distribution builds
• String changes made/needed: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9190643 [details]
Bug 1679728 - fix distribution support for browser.showPersonalToolbar, r?mkaply

Approved for 84.0b8.

Comment 10

[Mike Kaply [:mkaply]]

I've verified the fix in nightly.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/39f83bcc769f

Comment 12

[:Gijs (he/him)]

Marking this verified for nightly per comment 10. Thanks Mike!

Comment 13

[Andrei Purice]

Hey Mike,
Do you know how exactly can we test this issue? What are the exact steps and do we need a special build for it?

Comment 14

[Mike Kaply [:mkaply]]

(easiest on Windows)

Create a distribution directory where the Firefox executable is located.

Put the distribution.ini from here:

https://raw.githubusercontent.com/mozilla-partners/mozillaonline/master/desktop/mainWinFull/distribution/distribution.ini

In that directory.

Create a new profile.

Comment 15

[Peter Magyari (Desktop QA)]

Hi,

So I've created a distribution directory, saved the distribution.ini from the link above into it and created a new profile but the preferences/bookmarks from the .ini were not loaded in.

Mike, if you find the time would you mind verifying the fix on the Beta as well?

Thank you!

Comment 16

[Mike Kaply [:mkaply]]

Not sure what happened for you, but I just ran a quick test on the Firefox 84 RC and everything is working.