1679957 - Regression: VoiceOver no longer reads text in address bar

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Marco Zehe (:MarcoZ)]

This is a regression from bug 1672700. It rewrote a bunch of the MozTextAccessible stuff, which so far seems to have worked nicely in XUL text boxes, such as the one on the address bar. However, something got lost, so now text in the address bar is neither spoken nor brailled, not even after the fix for bug 1679075.

Steps:

1. With VoiceOver on, open Nightly.
2. Press Cmd+L to go to the address bar.
3. Try to read the text that is in there, or enter some text or an URL, and try to read it with left and right arrow keys.
   • Expected: VoiceOver reads the characters.
   • Actual: Nothing is spoken.
4. Turn on the Braille representation in the VoiceOver Utility, then return to Nightly and to the address bar.
5. Enter some more text.
   • Expected: Braille Viewer should show the text you enter.
   • Actual: Text remains blank.

Major functionality breakage, P1 and S2, assigning directly to Eitan to take a look.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1672700

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1679957 - Text range from accessible should return inner offsets for hypertexts. r?morgan!

UL documents have a bunch of non-hypetext accessibles in their heirarchy. So you can't assume
that a hyperlink's parent is a hypertext. To get around that, when we construct ranges for elements they should be internal ranges when possible.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/503d7bd90167
Text range from accessible should return inner offsets for hypertexts. r=morgan

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/503d7bd90167