Closed Bug 1679957 Opened 3 years ago Closed 3 years ago

Regression: VoiceOver no longer reads text in address bar

Categories

(Core :: Disability Access APIs, defect, P1)

Product:
Core
Component:
Disability Access APIs
Version:
Firefox 85
Platform:
Desktop
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- unaffected
firefox85 --- fixed

People

(Reporter: MarcoZ, Assigned: eeejay)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [Mac2020_2])

Attachments

(1 file)

Bug 1679957 - Text range from accessible should return inner offsets for hypertexts. r?morgan!
47 bytes, text/x-phabricator-request
Details | Review

This is a regression from bug 1672700. It rewrote a bunch of the MozTextAccessible stuff, which so far seems to have worked nicely in XUL text boxes, such as the one on the address bar. However, something got lost, so now text in the address bar is neither spoken nor brailled, not even after the fix for bug 1679075.

Steps:

  1. With VoiceOver on, open Nightly.
  2. Press Cmd+L to go to the address bar.
  3. Try to read the text that is in there, or enter some text or an URL, and try to read it with left and right arrow keys.
    • Expected: VoiceOver reads the characters.
    • Actual: Nothing is spoken.
  4. Turn on the Braille representation in the VoiceOver Utility, then return to Nightly and to the address bar.
  5. Enter some more text.
    • Expected: Braille Viewer should show the text you enter.
    • Actual: Text remains blank.

Major functionality breakage, P1 and S2, assigning directly to Eitan to take a look.

Set release status flags based on info from the regressing bug 1672700

status-firefox83: --- → unaffected
status-firefox84: --- → unaffected
status-firefox-esr78: --- → unaffected

UL documents have a bunch of non-hypetext accessibles in their heirarchy. So you can't assume
that a hyperlink's parent is a hypertext. To get around that, when we construct ranges for elements they should be internal ranges when possible.

Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/503d7bd90167
Text range from accessible should return inner offsets for hypertexts. r=morgan

https://hg.mozilla.org/mozilla-central/rev/503d7bd90167

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox85: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.