1679973 - Update newtab section preferences strings in about:preferences

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[:prathiksha]

The newtab page in Firefox is getting a new customization menu that lets users toggle section UI. Strings for toggling newtab UI in "about:preferences" under the "Home" section will need updating to match newly introduced customization menu srings.

See specs here: https://www.figma.com/file/hGOaTi5ufs2Ese6agbUN4G/New-New-Tab?node-id=985%3A9858

Comment 1

[:prathiksha]

Attachment: Bug 1679973 - Update newtab section preferences strings in about:preferences

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/372208ce70ad
Update newtab section preferences strings in about:preferences r=ewright,fluent-reviewers

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/372208ce70ad

Comment 4

[Robert Martin [:romartin], Ecosystem QA]

Hi @Prathiksha,

I've set the value of the following pref browser.newtabpage.activity-stream.customizationMenu.enabled to true and I can confirm that the following sections are displayed in the "about:preferences#home" page:
"Web Search", "Shortcuts", "Recommended by Pocket", "Recent activity", and "Snippets". That being said, according to the figma provided in the description, there should be no "Web Search" section. Can you please let me know what's the expected result in this case?

Comment 5

[:prathiksha]

(In reply to Robert Martin [:romartin], Ecosystem QA from comment #4)

Hi @Prathiksha,

I've set the value of the following pref browser.newtabpage.activity-stream.customizationMenu.enabled to true and I can confirm that the following sections are displayed in the "about:preferences#home" page:
"Web Search", "Shortcuts", "Recommended by Pocket", "Recent activity", and "Snippets". That being said, according to the figma provided in the description, there should be no "Web Search" section. Can you please let me know what's the expected result in this case?

Hi Robert, removal of the "Web Search" section is currently being tracked in Bug 1679960. So yes, it is expected that this bug is only tracking the rest of the string changes. :)

Comment 6

[Robert Martin [:romartin], Ecosystem QA]

Thank you @Prathiksa!

I have verified that if the browser.newtabpage.activity-stream.customizationMenu.enabled" pref value is set totrue` the following are displayed in the "about:preferences#home" page under the "Firefox Home Content" section:

• "Choose what content you want on your Firefox Home Screen." string.
• "Web Search" section title, a symbol, and a checkbox in front.
• "Shortcuts" section title and a symbol in front.
  • "Sites you save or visit" string underneath the title and a dropdown menu on the right side.
  • "Sponsored shortcuts" with a checkbox in front, if the profile is eligible to receive "Sponsored shortcuts".
• "Recommended by Pocket" section title, a symbol, a checkbox in front, and also a "How it works" hyperlink at the end.
  • "Exceptional content curated by Pocket, part of the Firefox family" string underneath the title.
  • "Sponsored Stories" with a checkbox in front, if the profile is eligible to receive "Sponsored Stories".
• "Recent activity" section title and a symbol in front.
  • "A selection of recent sites and content" string and a dropdown menu on the right side.
  • "Visited Pages" string with a checkbox in front.
  • "Bookmarks" string with a checkbox in front.
  • "Most Recent Download" string with a checkbox in front.
  • "Pages Saved to Pocket" string with a checkbox in front.
• "Snippets" section title, a symbol, and a checkbox in front.
  • "Tips and news from Mozilla and Firefox" string underneath the title.

The verification was done using Firefox Nightly 85.0a1 (20201211093444) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64.