Closed Bug 1680177 Opened 3 years ago Closed 3 years ago

On MacOS cmd-click on native menu fails to open in new tab

Categories

(Core :: Widget: Cocoa, defect, P1)

Product:
Core
Component:
Widget: Cocoa
Version:
78 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- verified

People

(Reporter: pwr, Assigned: mstange)

References

Details

(Whiteboard: [mac:ux][mac:mr1][proton-context-menus])

Attachments

(1 file)

Bug 1680177 - Set the correct modifier flags on command events dispatched by the native menu system. r=#mac-reviewers
48 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Click menu Bookmarks > cmd-click on any bookmark.

Actual results:

Bookmark replaces content of current tab.

Expected results:

Bookmark opens in new tab.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Bookmarks & History

Could you please be more specific about which bookmarks menu you are using, since we have more than one.
Are you using 78 ESR?
When the problem happens, do you see any errors reported in the Browser Console?

Flags: needinfo?(pwr)

Sorry, I refer to the main menu bar (top of screen in OS X), cmd-clicking bookmmarks here ought to open a new tab.

I am currently on 78 ESR (I downgraded OS X to 10.11 to for blood preasure reasons) however the same behaviour occurred before in 83 on macOS 10.15.

There is no console error.

Flags: needinfo?(pwr)
Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3

I believe this is a widget problem; the same issue exists for the history menu.

Component: Bookmarks & History → Widget: Cocoa
Product: Firefox → Core
Summary: cmd-click on bookmark in menu fails to open in new tab → On MacOS cmd-click on bookmark or history entry in top menu fails to open in new tab

I was planning to look into this.

Assignee: nobody → mstange.moz
Status: NEW → ASSIGNED
Whiteboard: [mac:ux]

This also affects native context menus. For example, with browser.proton.contextmenus.enabled and widget.macos.native-context-menus set to true, Cmd-clicking the Reload item in the page context menu doesn't open a new tab.

Blocks: 34572
Priority: P3 → P1
Summary: On MacOS cmd-click on bookmark or history entry in top menu fails to open in new tab → On MacOS cmd-click on native menu fails to open in new tab
Whiteboard: [mac:ux] → [mac:ux][mac:mr1][proton-context-menus]
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/27d4a4303d53
Set the correct modifier flags on command events dispatched by the native menu system. r=mac-reviewers,spohl
Blocks: 1700679

https://hg.mozilla.org/mozilla-central/rev/27d4a4303d53

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

This issue is verified fixed using Firefox 89.0a1 (BuildId:20210414160838) on macOS 10.15 with native menus enabled.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: