Comment on attachment 9217545 [details]
Bug 1700679 - Enable native context menus by default. r=harry
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1 / Proton
- Is this code covered by automated tests?: Yes, extensively
- Has the fix been verified in Nightly?: Yes with the pref flipped manually
- Needs manual test from QE?: Covered by native context menu QA testing
- List of other uplifts needed: 67 patches across 33 other bugs (most of which are test-only)
- Risk to taking this patch: Medium, but pref can be disabled if a show-stopper is found.
- Why is the change risky/not risky? (and alternatives if risky): See below.
- String changes made/needed: n/a
The 68 patches (67 in other bugs + the one in this bug) that need to be uplifted fall under the following categories:
- Test-only fixes (31 out of 68)
- Fixes to platform code that is only exercised by automated tests (8 out of 68)
- Code changes that affect all configurations (8 out of 68) (bug 1704948, bug 1707204 and bug 1707652)
- Code changes that only affect the native menu path (20 out of 68)
- The pref flip: Enabling native menus by default (1 out of 68) (this bug)
Categories 1 and 2 are extremely low risk. Category 3 is medium risk - these are the patches from bug 1704948, which affect code that handles middle mouse clicks on menuitems, on all platforms, and bug 1707204 and bug 1707652, which tweak code specific to the Downloads panel. Category 4 and 5 are medium risk because native menus have not had a lot of testing on Nightly. They've been usable on Nightly since April 2 by flipping prefs, but they weren't on by default. However, QA has been testing native context menus since then, and only found a small number of issues, most of which are fixed now. (The only two remaining open issues are bug 1705157 and bug 1706966.)
Another mitigating factor for the risk is the enormous test coverage we have for context menus. All these tests are now running with native menus. During the test-fixing initiative we came across all kinds of menus in all kinds of configurations, and they all worked.
Furthermore, if any show-stopper issues are found, we can still disable the pref.
The full list of patches that need to be uplifted can be obtained from the try push: https://hg.mozilla.org/try/pushloghtml?changeset=ea3fdd35a009e7881da64168b840c7ad24c956cf