Closed Bug 1680229 Opened 5 years ago Closed 5 years ago

anchor tag download attribute not working

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Version:
Firefox 84
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1689018
Tracking Flags:
Tracking Status
firefox-esr78 --- wontfix
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- wontfix
firefox86 --- wontfix
firefox87 --- fixed

People

(Reporter: harald, Unassigned)

References

(Regression)

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

Visit: https://sammlung.wienmuseum.at/en/object/686660-reformkleid/
Click on the "download icon" (downwards pointing arrow) which appears when you hover the object image. A modal appears with a download link. This download link has a download attribute with the suggested filename. When I click the download link, the image opens in the browser.

Safari and Chrome work as expected.

Actual results:

Image opens in browser.

Expected results:

A download dialog appears with the suggested filename.

Summary: anchor tag download → anchor tag download attribute not working

Thanks for the report. This seems to be a pretty old regression.

3:26.76 INFO: Last good revision: 47d7c18620c845c3a42610fea5468ccc50889bae (2019-10-22)
3:26.76 INFO: First bad revision: 82274c20257455ffb7ea74404ee9d27bc4246819 (2019-10-23)
3:26.76 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=47d7c18620c845c3a42610fea5468ccc50889bae&tochange=82274c20257455ffb7ea74404ee9d27bc4246819

Disabling browser.tabs.documentchannel in the bad revision fixes it, so this is caused by Bug 1583700.

Flags: needinfo?(matt.woodrow)
Regressed by: 1583700
Has Regression Range: --- → yes
Component: Untriaged → Networking
Product: Firefox → Core
Status: UNCONFIRMED → NEW
status-firefox83: --- → affected
status-firefox84: --- → affected
status-firefox85: --- → affected
Ever confirmed: true

Seems like Matt maybe stopped working on this. Anny can you take a look?

Flags: needinfo?(agakhokidze)

I think this is a serviceworkers issue.

It looks like we don't preserve the download attribute across redirects, and this page has an internal redirect to a service worker intercepted channel.

The download handling runs in the parent, as does the service worker interception, so the final channel doesn't have GetContentDisposition() == nsIChannel::DISPOSITION_ATTACHMENT)

Flags: needinfo?(matt.woodrow) → needinfo?(bugmail)

This seems to have stalled again. Bug 1686754 is probably duplicate.

Fixed now:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e259e253b3da343043028430d5d3062c37735969&tochange=2f575c3c4353b2c5adc27519e55ca4f3c125a1d2
So Bug 1689018.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(bugmail)
Flags: needinfo?(agakhokidze)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.