1680273 - Move ASRouter telemetry call from child actor to parent

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

Moving the telemetry call into the parent works around some of the issues found in bug 1677723:

• We cannot properly use client_id because of pref access restrictions
• Similarly other telemetry data cannot be accessed from the child context

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1680273 - Move ASRouter telemetry call from child actor to parent

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66774ae869fd
Move ASRouter telemetry call from child actor to parent r=k88hudson

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/66774ae869fd

Comment 4

[Andrei Oprea [:andreio]]

We need to verify that snippets telemetry reports the expected information.

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

We have verified this enhancement and I can confirm the following:

• verified that the "client_id" value is successfully displayed for the "IMPRESSION", "CLICK" and "BLOCK" telemetry ping of the "NEWTAB_FOOTER_BAR" snippet.
• verified that the "client_id" value is also displayed in the snippets telemetry pings from the "snippets_local_testing" section of the "AS Router Admin" page.
• verified that no regressions occurred in the "CLICK", "BLOCK" telemetry pings of the cards from the "Top Sites", "Recommended by Pocket", and "Highlights" sections.
• verified using the "gzipServer" tool that the telemetry pings are successfully sent and received by a local telemetry server.

Verified using the latest Firefox Nightly (85.0a1 Build ID - 20201211093444) installed on Windows 10 x64, macOS 10.15, and Ubuntu Linux 20 x64.