1680313 - Revert media.navigator.mediadatadecoder_vpx_enabled to false

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Nils Ohlmeier [:drno]]

The change in bug 1665329 appears to cause resolution problems with some WebRTC calls. Let's revert the pref until we can find the bug in the Media Data Decoder.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1680313: set media.navigator.mediadatadecoder_vpx_enabled to false

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92546b26a0be
set media.navigator.mediadatadecoder_vpx_enabled to false r=ng

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 9190889 [details]
Bug 1680313: set media.navigator.mediadatadecoder_vpx_enabled to false

Beta/Release Uplift Approval Request

• User impact if declined: Videos in WebRTC calls under some circumstances (after switching back from screen sharing to normal video) render only at the quarter of the intended size.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We are reverting user prefs to the settings we had before, which did not cause problems.
• String changes made/needed: N/A

Comment 4

[Jean-Yves Avenard [:jya]]

I believe a better approach would be to force using libvpx instead for now. We still enjoy higher level of security and also better performance (as we directly copy in GPU images where we can).

Right now we would be using ffvp9/ffvp9 ; to prevent using it we reset the pref allowing to use those when low latency flag is set.

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/92546b26a0be

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1665329

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9190889 [details]
Bug 1680313: set media.navigator.mediadatadecoder_vpx_enabled to false

Approved for 84.0b8 to fix the immediate issue. Sounds like we may want a follow-up bug filed for comment 4 to ship a better fix for 85+?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7dd495ffa5f3

Comment 9

[Nils Ohlmeier [:drno]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)

Approved for 84.0b8 to fix the immediate issue. Sounds like we may want a follow-up bug filed for comment 4 to ship a better fix for 85+?

There is another bug where Jean-Yves provided a workaround for the encountered problem. But at the same time we are still chasing the underlying root cause, which we haven't identified yet.
My current thinking is to leave things as they are in Nightly until we have identified the root cause. Once we have fixed that we should attempt to let the pref flip ride to release again.