1665329 - Set media.navigator.mediadatadecoder_vpx_enabled to true for release

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

Set media.navigator.mediadatadecoder_vpx_enabled to true for release.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1665329 Enable media.navigator.mediadatadecoder_vpx_enabled for release, r?jya

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8ceb5f2167f
Enable media.navigator.mediadatadecoder_vpx_enabled for release, r=jya,drno

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c8ceb5f2167f

Comment 4

[Vincent Chernin]

Since 1680313 set media.navigator.mediadatadecoder_vpx_enabled to not be true for release, shouldn't this bug be reopened?

Comment 5

[Nils Ohlmeier [:drno]]

Looks like I either lost the ability to reopen bugs, or it is in general no longer possible.
It is probably cleaner to leave this bug as is and open a new bug instead.

Comment 6

[Vincent Chernin]

New bug for this issue is Bug #1709009

Comment 7

[Chris Peterson [:cpeterson]]

Martin, the media.navigator.mediadatadecoder_vpx_enabled pref has been enabled in Firefox Release on Linux since 2022 (bug 1709009) and in Nightly on Windows and macOS since at least 2019. Is it safe to let mediadatadecoder_vpx_enabled ride the trains on Windows and macOS now?

Bug 1709009 comment 0 says this pref "enables FFMPEG VA-API decoding (Bug #1610199) support for WebRTC on Linux (Bug #1646329)", but mediadatadecoder_vpx_enabled has been enabled on Linux since 2022 and FFMPEG VA-API bug 1610199 is still open.

https://searchfox.org/mozilla-central/rev/09b59a7de6848639f27297888889a06e97561074/modules/libpref/init/StaticPrefList.yaml#10837-10845

Comment 8

[Martin Stránský [:stransky] (ni? me)]

(In reply to Chris Peterson [:cpeterson] from comment #7)

Martin, the media.navigator.mediadatadecoder_vpx_enabled pref has been enabled in Firefox Release on Linux since 2022 (bug 1709009) and in Nightly on Windows and macOS since at least 2019. Is it safe to let mediadatadecoder_vpx_enabled ride the trains on Windows and macOS now?

Bug 1709009 comment 0 says this pref "enables FFMPEG VA-API decoding (Bug #1610199) support for WebRTC on Linux (Bug #1646329)", but mediadatadecoder_vpx_enabled has been enabled on Linux since 2022 and FFMPEG VA-API bug 1610199 is still open.

https://searchfox.org/mozilla-central/rev/09b59a7de6848639f27297888889a06e97561074/modules/libpref/init/StaticPrefList.yaml#10837-10845

media.navigator.mediadatadecoder_vpx_enabled was disabled on Linux due to Bug 1790729. But we created extra option for VP8 for it so I think it's safe now to enable it for Linux.

I can't say for Windows / MacOS, media folks should know better.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Filed Linux one as Bug 1886400.

Comment 10

[Paul Adenot (:padenot)]

We're investigating re-enabling of platform encoders for WebRTC as part of the Web Codecs effort, since this all need to work.