1680329 - Slack: When going down from the last message into the message entry field, VoiceOver focus remains on last message.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Marco Zehe (:MarcoZ)]

Steps:

1. Set Slack to move into the message list when pressing UpArrow from the message entry field. This is an Accessibility preference in the Slack UI.
2. Move from the message entry to the list.
3. Press DownArrow to go back to the message entry field.
   • Expected: VoiceOver says "Enter message text".
   • Actual: VoiceOver tries to say that, but gets interrupted by itself when it speaks the message of the last entry of the list again.

Eitan confirmed that visually, VoiceOver focus is on the text of the last message while keyboard focus is in the actual text field.

Comment 1

[Marco Zehe (:MarcoZ)]

Nominating for 86 work. Seems like there is a lead, but if it turns out to need more time, feel free to bump to 87 or backlog.

Comment 2

[Eitan Isaacson [:eeejay]]

Now that bug 1682692 is fixed, i wonder if this is related. Marco can you check to see if this is still an issue?

Comment 3

[Marco Zehe (:MarcoZ)]

This is no longer reproduce with the 2nd December 16, 2020 Nightly build, which contains the fix for bug 1682692. Closing.

Comment 4

[Marco Zehe (:MarcoZ)]

Looks like I was a bit quick with closing this one. After some time, it reappeared, and now is reproducible again just like it was before. Don't know why it didn't expose itself intermittently, but now it's back in full force. Reopening.

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1680329 - Add AXTextStateChangeType to selection events. r?morgan!

It seems that VoiceOver depends on that property to know if a selection is be extended or moved. This manifests in several places in Slack when the user combines VO navigation with Slack's keyboard navigation.

Also changed where we retrieve the editable ancestor to simplify the notification dispatching block.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5712fdcdf04f
Add AXTextStateChangeType to selection events. r=morgan

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5712fdcdf04f

Comment 8

[Julien Cristau [:jcristau]]

Do we want this on 85 as well?

Comment 9

[Eitan Isaacson [:eeejay]]

No. We will just let this ride the trains. 86 is our target.

Comment 10

[Rares Doghi, Desktop QA]

Hi Eitan, I tried to Verify this issue but after setting the accesibility option in slack to "Move Focus to the message list" I'm getting the exact same behavior in Firefox 85 as well as 86.0b3, I cannot reproduce the above mentioned issue, are there any other keyboard settings or Voice Over Utility settings I should check in order to reproduce the issue ?

In both 85 and 86 when going back down to the "Enter text" field I get the same message:

Message @user , edit text, New line, Insertion at the begining of text. Conversation with @user main
You are currently on a text area.

I am testing this issue on a mac 10.15.