1680596 - Hide <menuitem> behind a flag

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1680596 - Part 1: Hide <menuitem> behind a flag r=smaug

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Not sure how to conditionally turn off menu[type="context"] style rule. Emilio, could you help?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

@supports -moz-bool-pref("....") can be used in UA sheets. Requires a restart but that's probably ok for your purposes.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Cool, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ea7d760b4a8
Hide <menuitem> behind a flag r=smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5fce6a4b5b9
Move the pref at the begining of the manifest. a=trivial-fix CLOSED TREE

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da913c816303
Backed out 2 changesets for xpcshell and mochitest plain failures. CLOSED TREE

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for xpcshell and mochitest plain failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&revision=8ea7d760b4a83c6646989bd4ae81a01e8c3472de&searchStr=xpc&selectedTaskRun=Ky_gbIWnTm-ZMk9pnmUMVA.0

Failure logs: https://treeherder.mozilla.org/logviewer?job_id=323809353&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=323808343&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/da913c8163038ac145204d1af35910e84c9cd2d1

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1680596 - Part 2: Replace the use of HTML menuitem in a LoginManagerContextMenu test r=tgiles

Depends on D98684

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cc287d1291e
Part 1: Hide <menuitem> behind a flag r=smaug
https://hg.mozilla.org/integration/autoland/rev/4ff8babaa774
Part 2: Replace the use of HTML menuitem in a LoginManagerContextMenu test r=tgiles

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6cc287d1291e
https://hg.mozilla.org/mozilla-central/rev/4ff8babaa774

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/af42644bed94
Port bug 1680596 - Hide <menuitem> behind a flag. rs=bustage-fix

Comment 13

[Rachel Andrew]

BCD and update to release notes are done pending merge.

Comment 14

[Anthony Lieuallen]

What should I as a web and/or extension developer expect as a result of this?

Should I expect <menu type="context"> (and <menuitem> inside it) behavior (for registering items in the general right click/context menu) to change? Should I expect visible <menu> and <menuitem> behavior to change? Should I expect JS DOM access to these elements to change? Something else?

Should I expect these changes to already be in effect for Nightly?

Comment 15

[Kagami Rosylight [:saschanaz] (they/them)]

Yes, <menu type="context"> is not a thing anymore and it works as a typical <menu> (which again is roughly an equivalent of <ul>). <menuitem> is now gone and thus gives no effect anymore.

The changes are in Nightly and also in Beta.

Comment 16

[Anthony Lieuallen]

Repro case: https://github.com/greasemonkey/greasemonkey/issues/3101#issuecomment-766438363

I'm finding that using <menuitem> in an HTML doc is now actively broken (in Nightly). Specifically: when JS sets the disabled property, no matching DOM attribute is created.

Comment 17

[Kagami Rosylight [:saschanaz] (they/them)]

That's expected because we are dropping <menuitem>. It's also dropped from the HTML spec because of no implementer interest, so extensions shouldn't rely on it.

See also: https://groups.google.com/g/mozilla.dev.platform/c/tc11BCenm2c