Closed Bug 1680596 Opened 3 years ago Closed 3 years ago

Hide <menuitem> behind a flag


(Core :: DOM: Core & HTML, enhancement, P2)




85 Branch
Tracking Status
firefox85 --- fixed


(Reporter: saschanaz, Assigned: saschanaz)



(Keywords: dev-doc-complete)


(2 files)

No description provided.

Not sure how to conditionally turn off menu[type="context"] style rule. Emilio, could you help?

Flags: needinfo?(emilio)

@supports -moz-bool-pref("....") can be used in UA sheets. Requires a restart but that's probably ok for your purposes.

Flags: needinfo?(emilio)

Cool, thanks!

Severity: -- → S3
Priority: -- → P2
Attachment #9191153 - Attachment description: Bug 1680596 - Hide <menuitem> behind a flag → Bug 1680596 - Hide <menuitem> behind a flag r=smaug
Pushed by
Hide <menuitem> behind a flag r=smaug
Pushed by
Move the pref at the begining of the manifest. a=trivial-fix CLOSED TREE
Backout by
Backed out 2 changesets for xpcshell and mochitest plain failures. CLOSED TREE
Flags: needinfo?(krosylight)
Attachment #9191153 - Attachment description: Bug 1680596 - Hide <menuitem> behind a flag r=smaug → Bug 1680596 - Part 1: Hide <menuitem> behind a flag r=smaug
Pushed by
Part 1: Hide <menuitem> behind a flag r=smaug
Part 2: Replace the use of HTML menuitem in a LoginManagerContextMenu test r=tgiles
Keywords: dev-doc-needed
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Pushed by
Port bug 1680596 - Hide <menuitem> behind a flag. rs=bustage-fix

BCD and update to release notes are done pending merge.

What should I as a web and/or extension developer expect as a result of this?

Should I expect <menu type="context"> (and <menuitem> inside it) behavior (for registering items in the general right click/context menu) to change? Should I expect visible <menu> and <menuitem> behavior to change? Should I expect JS DOM access to these elements to change? Something else?

Should I expect these changes to already be in effect for Nightly?

Yes, <menu type="context"> is not a thing anymore and it works as a typical <menu> (which again is roughly an equivalent of <ul>). <menuitem> is now gone and thus gives no effect anymore.

The changes are in Nightly and also in Beta.

Repro case:

I'm finding that using <menuitem> in an HTML doc is now actively broken (in Nightly). Specifically: when JS sets the disabled property, no matching DOM attribute is created.

That's expected because we are dropping <menuitem>. It's also dropped from the HTML spec because of no implementer interest, so extensions shouldn't rely on it.

See also:

Regressions: 1691755
You need to log in before you can comment on or make changes to this bug.