Closed Bug 1691639 Opened 4 years ago Closed 4 years ago

jquery.contextMenu.js and jquery-ui.js not working after upgrade to Firefox 85

Categories

(Core :: Layout: Tables, task)

Firefox 85
task

Tracking

()

RESOLVED DUPLICATE of bug 1680596

People

(Reporter: mail2alitauseef, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.146 Safari/537.36

Steps to reproduce:

Earlier I was getting customized menu on right click but after upgrade to the Firefox version 85 its not coming (only default menu is listed). The same code works well with lesser version of Firefox i.e., version 84 or version 83.

Actual results:

Below is the scripts being used:

<link href="/css/repair/jquery-ui.css" rel="stylesheet">
<link rel="stylesheet" type="text/css" href="/css/dashboard/jquery.contextMenu.css" />
<script src="/css/repair/external/jquery/jquery.js"></script>
<script src="/js/dashboard/jquery.ui.position.js" type="text/javascript"></script>
<script src="/js/dashboard/jquery.contextMenu.js" type="text/javascript"></script>
<script type="text/javascript" src="/js/dashboard/FunctionsRepairData.js"></script>
<meta http-equiv="content-type" content="text/html; charset=utf-8" />
<script src="/css/repair/jquery-ui.js"></script>

Below is the code which is being used:

//add context menu if rows is selected
$(function() {$( "#RunSelectable" ).selectable({
stop: function()
{
var table = document.getElementById("SpiderRunTab");
var spiderrunids = "";
var current = table.rows[1].cells[0].firstChild.value;
for (var i = 1, row; row = table.rows[i]; i++)
if (row.className == "ui-widget-content ui-selectee ui-selected")
spiderrunids += row.cells[0].firstChild.value + ',';
spiderrunids = spiderrunids.substring(0, spiderrunids.length - 1);
$( ".ui-selected", this ).each(function()
{
if (this.firstChild != null)
{
if (this.firstChild.firstChild != null)
{
var id = (this).firstChild.firstChild.value;

                if (typeof id != "undefined")
                {
                    var menu = document.getElementById("mymenuSR" + id);
                    if(menu != null)
                    {
                        if(menu.children.length > 0)
                            menu.removeChild(menu.firstChild);

                        if ((this).lastChild.innerHTML !== "Already in the table")
                        {
                            var menuitem = document.createElement("menuitem");
                            menuitem.setAttribute("label", "Send selected runs in data repair run work table");
                            menuitem.setAttribute("onclick", "InsertInTable(\""+ spiderrunids + "\",\"" + current + "\")");
                            menu.appendChild(menuitem);
                        }

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Tables' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Layout: Tables
Product: Firefox → Core

<menuitem> was disabled in Firefox 85.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Group: core-security
Type: defect → task

Not a security bug, please don't set the security flag.

Group: core-security
You need to log in before you can comment on or make changes to this bug.