1680762 - Can't click the "Manage bookmarks..." link in the placeholder message in the toolbar

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[:Gijs (he/him)]

I broke this in bug 1678921.

We need to fix the link clicks without regressing the drag/drop functionality. Because the link and the drag/drop handlers are in different DOM subtrees and event dispatch only picks one path, this isn't fixable using pure CSS on its own - we'll need to either change the DOM, change where the event listeners are, or do event redirection in one way or another.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1678921

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1680762 - ensure both link clicks and drag/drop into the bookmarks toolbar works, r?jaws!,mak!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82046518530a
ensure both link clicks and drag/drop into the bookmarks toolbar works, r=jaws,mak

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_drag_bookmarks_on_toolbar.js

backout: https://hg.mozilla.org/integration/autoland/rev/a2f141ef8e0aad117c9d8f70a2ae9ad294314df9

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=82046518530a82b0f553fc8c12fbef23ce5b0171&searchStr=browser-chrome&selectedTaskRun=a738scuFSECECB7ieEfVBg.0&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=324052076&repo=autoland&lineNumber=2556

[task 2020-12-09T15:56:41.779Z] 15:56:41 INFO - TEST-PASS | browser/components/places/tests/browser/browser_drag_bookmarks_on_toolbar.js | Toolbar node has an associated Places node. -
[task 2020-12-09T15:56:41.780Z] 15:56:41 INFO - Dragging left
[task 2020-12-09T15:56:41.780Z] 15:56:41 INFO - A dragstart event has been trapped.
[task 2020-12-09T15:56:41.780Z] 15:56:41 INFO - Buffered messages finished
[task 2020-12-09T15:56:41.780Z] 15:56:41 INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_drag_bookmarks_on_toolbar.js | Number of dragged items should be the same. - Got +0, expected 1
[task 2020-12-09T15:56:41.780Z] 15:56:41 INFO - Stack trace:
[task 2020-12-09T15:56:41.781Z] 15:56:41 INFO - chrome://mochikit/content/browser-test.js:test_is:1332
[task 2020-12-09T15:56:41.781Z] 15:56:41 INFO - chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_drag_bookmarks_on_toolbar.js:listener:35
[task 2020-12-09T15:56:41.781Z] 15:56:41 INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtPoint:590
[task 2020-12-09T15:56:41.781Z] 15:56:41 INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouse:522
[task 2020-12-09T15:56:41.781Z] 15:56:41 INFO - chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_drag_bookmarks_on_toolbar.js:synthesizeDragWithDirection:133
[task 2020-12-09T15:56:41.781Z] 15:56:41 INFO - chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_drag_bookmarks_on_toolbar.js:test_drag_folder_on_toolbar:203
[task 2020-12-09T15:56:41.781Z] 15:56:41 INFO - Dragging right
[task 2020-12-09T15:56:41.782Z] 15:56:41 INFO - A dragstart event has been trapped.
[task 2020-12-09T15:56:41.782Z] 15:56:41 INFO - Not taking screenshot here: see the one that was previously logged

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fe5aa73cece
ensure both link clicks and drag/drop into the bookmarks toolbar works, r=jaws,mak

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8fe5aa73cece