1832537 - Dragging bookmarks vertically slightly in the toolbar causes them to move to the end of the list (disappear into overflow chevron)

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P3)

Description

[Kestrel]

Attachment: Vertically dragged bookmark moves to the end of the list

STR:

1. Open the bookmarks toolbar (Ctrl+Shift+B).
2. Make sure there are several bookmarks.
3. Drag a bookmark near the beginning of the toolbar vertically without leaving the toolbar.

Expected:
The drop marker stays in the same place.

Actual:
The drop marker moves to the end of the toolbar which is not visible if it is overflowing.

Bookmarks can be dragged by accident into this zone when clicking on them, making them disappear into the overflow chevron which is surprising and unexpected.

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7765d979d044be1fb03054013474a22e0b9ea022&tochange=7a6d6b986a1ed263db6d19ecbd56e2f4210870cf

Possibly regressed by Bug 1680762.

Comment 1

[Marco Bonardo [:mak]]

It's indeed the same root cause as Bug 1399595, dropping on the empty toolbar space appends, that applies to any empty space, included padding, margins...

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:Gijs, since you are the author of the regressor, bug 1680762, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Marco Bonardo [:mak]]

I don't think this is super critical to be fixed immediately considered bug 1399595 is there from 6 years. Thus clearing the needinfo to avoid wasting Gijs time.
It would be better to actually address the problem by fixing the drop position in Places Views, rather than some workaround or fix.

Comment 4

[Dan]

In other words, has bug 1399595 finally been assigned super high priority, after 6 years of us countless times being affected by that bug? That one is highly likely still the most encountered bug by Firefox users who are making good use of the bookmarks toolbar, after all...

Comment 5

[Marco Bonardo [:mak]]

I'd love to give a few bugs a "super high priority", but resources are limited and every Mozilla developer is super busy.
I agree with you that this set of bugs can be very annoying and it should get attention asap. We should have some time in June, unless someone else contributes a patch sooner.
I can see some possible solutions:

1. remove margins, though this demonstrated to be fragile, and these bugs are the result of that
2. add a drop box just after bookmarks that will flex with them, only allow to drop on it
3. calculate the drop position taking into account immediate adjacent bookmarks (and not just what's under the cursor)

Comment 6

[Kestrel]

(In reply to Marco Bonardo [:mak] from comment #5)

3. calculate the drop position taking into account immediate adjacent bookmarks (and not just what's under the cursor)

This was implemented in Bug 1399595 which has resolved the issue.