168084 - type ahead find in links mode matches text inside <a name=foo>

Status: VERIFIED FIXED

(SeaMonkey :: Find In Page, defect, P1)

Description

[Jeremy M. Dolan]

type ahead find in links mode matches text inside <a name=foo>

To reproduce, search for "conf" here in links mode.
http://www.mozilla.org/releases/mozilla1.2a/
It goes to non href header text.

2002091108 Linux.

Comment 1

[Aaron Leventhal]

Attachment: Checks nsILink::GetHrefCString

Seeking r=

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 98817 [details] [diff] [review]
Checks nsILink::GetHrefCString

Um.. GetHrefCString is expensive.  How about using nsIContent::HasAttr instead?

Comment 3

[Aaron Leventhal]

Bz, I'm looking for something that will work in XML. 

Will nsILink be supported on those? And if so, I would think GetHrefCstring
would be more likely to work that checking an attribute. 

Comment 4

[Boris Zbarsky [:bzbarsky]]

Oh, you want it to work with XLinks?  Those don't support nsILink.  Further,
<link> elements and <area> elements both implement nsILink (not sure whether you
care about that or not in this case).

Comment 5

[Aaron Leventhal]

I will open up a separate bug on Xlink support. 

I won't care about <area> until we can search text equivalents.

Comment 6

[Aaron Leventhal]

Attachment: Uses nsIDOMElement::HasAttribute since we don't have an atom table for nsIContent::HasAttr()

Seeking r=/sr=

Comment 7

[Aaron Leventhal]

Attachment: Okay I get it now - use nsIContent::HasAttr() with do_GetAtom

Seeking r=/sr= for real this time

Comment 8

[Aaron Leventhal]

Attachment: I've never had so many patches for such a simple bug :)

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 98854 [details] [diff] [review]
I've never had so many patches for such a simple bug :)

r/sr=bzbarsky

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 98854 [details] [diff] [review]
I've never had so many patches for such a simple bug :)

r=caillon

Comment 11

[Aaron Leventhal]

checked in

Comment 12

[sairuh (rarely reading bugmail)]

vrfy'd with this test case (2002.09.24.08 moz trunk):

1. load http://mozilla.org/quality/browser/front-end/testcases/keyboard-nav/
2. typeahead find for the named anchor "refs"

results: not found, as expected.