1680877 - [Fission] Content scripts not working in extension popups

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[carlos]

Content scripts are not being applied to iframes within extension popups with fission enabled. When opening the ext popup url in a new tab, everything works as expected.

Related issue: 1587541 (yet claims to be fixed?)

This issue breaks a lot of the functionality of Black Menu for Google
https://addons.mozilla.org/en-US/firefox/addon/black-menu-google/

Comment 1

[Tomislav Jovanovic :zombie]

I have a patch.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking for Fission M6c

Comment 3

[Tomislav Jovanovic :zombie]

Attachment: Bug 1680877 - Enable content scripts in extension popups and sidebars

See comment in ExtensionPolicyService::CheckDocument for details.

Comment 4

[Tomislav Jovanovic :zombie]

(In reply to carlos from comment #0)

Related issue: 1587541 (yet claims to be fixed?)

This issue breaks a lot of the functionality of Black Menu for Google
https://addons.mozilla.org/en-US/firefox/addon/black-menu-google/

I forgot this in bug 1587541, Thanks for testing with fission and for the report Carlos!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d25024d5811
Enable content scripts in extension popups and sidebars r=rpl

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_ext_menus_events.js

backout: https://hg.mozilla.org/integration/autoland/rev/caad18e8c1ec28646bd3bfa0254737d4e51d5744

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=9d25024d58113448ef2fd1e38c10508b46bfd995&searchStr=browser-chrome&group_state=expanded&selectedTaskRun=PxU-qvhZT_q2v-rv4apM2A.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=324048720&repo=autoland&lineNumber=2964

[task 2020-12-09T15:22:46.712Z] 15:22:46 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_menus_events.js | Expect widget not to be overflowed -
[task 2020-12-09T15:22:46.712Z] 15:22:46 INFO - Console message: [JavaScript Error: "NotSupportedError: WindowGlobalChild.getActor: Window protocol 'LoginManager' doesn't match message manager group" {file: "resource://gre/modules/LoginManagerChild.jsm" line: 517}]
[task 2020-12-09T15:22:46.712Z] 15:22:46 INFO - forWindow@resource://gre/modules/LoginManagerChild.jsm:517:27
[task 2020-12-09T15:22:46.713Z] 15:22:46 INFO - handleEvent@resource:///actors/ContextMenuChild.jsm:572:43
[task 2020-12-09T15:22:46.714Z] 15:22:46 INFO - synthesizeMouseAtPoint@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:590:32
[task 2020-12-09T15:22:46.714Z] 15:22:46 INFO - synthesizeMouse/<@resource://testing-common/BrowserTestUtilsChild.jsm:334:34
[task 2020-12-09T15:22:46.715Z] 15:22:46 INFO - wrapHandlingUserInput@resource://gre/modules/E10SUtils.jsm:848:7
[task 2020-12-09T15:22:46.715Z] 15:22:46 INFO - synthesizeMouse@resource://testing-common/BrowserTestUtilsChild.jsm:330:15
[task 2020-12-09T15:22:46.716Z] 15:22:46 INFO - receiveMessage@resource://testing-common/BrowserTestUtilsChild.jsm:149:21
[task 2020-12-09T15:22:46.716Z] 15:22:46 INFO -
[task 2020-12-09T15:22:46.717Z] 15:22:46 INFO - Buffered messages logged at 15:20:52
[task 2020-12-09T15:22:46.717Z] 15:22:46 INFO - Console message: [JavaScript Error: "1607527252030 addons.xpi ERROR System addon update list error Error: got node name: html, expected: updates" {file: "resource://gre/modules/Log.jsm" line: 723}]
[task 2020-12-09T15:22:46.718Z] 15:22:46 INFO - append@resource://gre/modules/Log.jsm:723:12
[task 2020-12-09T15:22:46.719Z] 15:22:46 INFO - log@resource://gre/modules/Log.jsm:379:16
[task 2020-12-09T15:22:46.719Z] 15:22:46 INFO - error@resource://gre/modules/Log.jsm:387:10
[task 2020-12-09T15:22:46.719Z] 15:22:46 INFO - updateSystemAddons/res<@resource://gre/modules/addons/XPIInstall.jsm:4016:25
[task 2020-12-09T15:22:46.720Z] 15:22:46 INFO -
[task 2020-12-09T15:22:46.731Z] 15:22:46 INFO - Buffered messages finished
[task 2020-12-09T15:22:46.731Z] 15:22:46 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_menus_events.js | Test timed out -
[task 2020-12-09T15:22:46.731Z] 15:22:46 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-12-09T15:22:46.732Z] 15:22:46 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_menus_events.js | Extension left running at test shutdown -
[task 2020-12-09T15:22:46.733Z] 15:22:46 INFO - Stack trace:
[task 2020-12-09T15:22:46.733Z] 15:22:46 INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-12-09T15:22:46.734Z] 15:22:46 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:117
[task 2020-12-09T15:22:46.735Z] 15:22:46 INFO - chrome://mochikit/content/browser-test.js:nextTest:555
[task 2020-12-09T15:22:46.735Z] 15:22:46 INFO - GECKO(1535) | MEMORY STAT | vsize 20976032MB | residentFast 1876MB
[task 2020-12-09T15:22:46.735Z] 15:22:46 INFO - TEST-OK | browser/components/extensions/test/browser/browser_ext_menus_events.js | took 180169ms

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d6e33c22839
Enable content scripts in extension popups and sidebars r=rpl

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6d6e33c22839