1680900 - comm-central perma fail - toolkit/components/extensions/test/xpcshell/test_ext_browsingData.js, test_ext_browsingData_cookies_cache.js, test_ext_browsingData_cookies_cookieStoreId.js | xpcshell return code: 0

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=323652262&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/WGeWxWbATDq9KcLohH1KmQ/runs/0/artifacts/public/logs/live_backing.log

---

As well as 
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_browsingData_cookies_cache.js | xpcshell return code: 0
Logviewer
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_browsingData_cookies_cookieStoreId.js | xpcshell return code: 0 

Regressed by something from https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=7ce95b6cde2643be60ec53d8c743db28aec30884

[task 2020-12-05T11:57:20.237Z] 11:57:20     INFO -  xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_browsingData.js | Starting testInvalidArguments
[task 2020-12-05T11:57:20.238Z] 11:57:20     INFO -  (xpcshell/head.js) | test testInvalidArguments pending (2)
[task 2020-12-05T11:57:20.238Z] 11:57:20     INFO -  "Extension attached"
[task 2020-12-05T11:57:20.238Z] 11:57:20     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2020-12-05T11:57:20.238Z] 11:57:20     INFO -  Unexpected exception Error: Warning processing permissions: Error processing permissions.0: Value "browsingData" must either: must either [must either [must either [must either [be one of ["idle"], be one of ["menus.overrideContext"], be one of ["activeTab"], be one of ["cookies"], or be one of ["webRequest", "webRequestBlocking"]], be one of ["clipboardRead", "clipboardWrite", "geolocation", "notifications"], be one of ["accountsRead"], be one of ["addressBooks"], be one of ["compose"], be one of ["messagesModify"], be one of ["accountsFolders"], be one of ["messagesMove", "messagesRead"], be one of ["pkcs11"], be one of ["tabs", "tabHide"], be one of ["browserSettings"], be one of ["downloads", "downloads.open"], be one of ["management"], be one of ["privacy"], be one of ["proxy"], or be one of ["webNavigation"]], be one of ["alarms", "mozillaAddons", "storage", "unlimitedStorage"], be one of ["geckoProfiler"], be one of ["identity"], be one of ["menus"], be one of ["contextualIdentities"], be one of ["dns"], be one of ["activityLog"], be one of ["networkStatus"], be one of ["telemetry"], or be one of ["theme"]], must either [must either [be one of ["idle"], be one of ["menus.overrideContext"], be one of ["activeTab"], be one of ["cookies"], or be one of ["webRequest", "webRequestBlocking"]], be one of ["clipboardRead", "clipboardWrite", "geolocation", "notifications"], be one of ["accountsRead"], be one of ["addressBooks"], be one of ["compose"], be one of ["messagesModify"], be one of ["accountsFolders"], be one of ["messagesMove", "messagesRead"], be one of ["pkcs11"], be one of ["tabs", "tabHide"], be one of ["browserSettings"], be one of ["downloads", "downloads.open"], be one of ["management"], be one of ["privacy"], be one of ["proxy"], or be one of ["webNavigation"]], be one of ["nativeMessaging"], or match the pattern /^experiments(\\.\\w+)+$/], or must either [be one of ["<all_urls>"], must either [match the pattern /^(https?|wss?|file|ftp|\\*):\\/\\/(\\*|\\*\\.[^*/]+|[^*/]+)\\/.*$/, or match the pattern /^file:\\/\\/\\/.*$/], or match the pattern /^resource:\\/\\/(\\*|\\*\\.[^*/]+|[^*/]+)\\/.*$|^about:/] at resource://gre/modules/Schemas.jsm:1243
[task 2020-12-05T11:57:20.238Z] 11:57:20     INFO -  logWarning@resource://gre/modules/Schemas.jsm:1243:17
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  normalize@resource://gre/modules/Schemas.jsm:2225:16
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  checkProperty/r<@resource://gre/modules/Schemas.jsm:1906:16
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  withPath@resource://gre/modules/Schemas.jsm:603:14
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  checkProperty@resource://gre/modules/Schemas.jsm:1905:25
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  normalize@resource://gre/modules/Schemas.jsm:1978:14
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  normalize@resource://gre/modules/Schemas.jsm:3421:23
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  normalize@resource://gre/modules/Schemas.jsm:3611:28
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  _getNormalizedManifest@resource://gre/modules/Extension.jsm:879:20
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  parseManifest@resource://gre/modules/Extension.jsm:929:33
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:239:6
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:568:5
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  @-e:1:1
[task 2020-12-05T11:57:20.241Z] 11:57:20     INFO -  exiting test
[task 2020-12-05T11:57:20.242Z] 11:57:20     INFO -  "CONSOLE_MESSAGE: (info) 1607169439897	addons.webextension.{78961bf9-57aa-4dc8-a9df-7ddda910fc30}	WARN	Loading extension '{78961bf9-57aa-4dc8-a9df-7ddda910fc30}': Reading manifest: Warning processing permissions: Error processing permissions.0: Value "browsingData" must either: must either [must either [must either [must either [be one of ["idle"], be one of ["menus.overrideContext"], be one of ["activeTab"], be one of ["cookies"], or be one of ["webRequest", "webRequestBlocking"]], be one of ["clipboardRead", "clipboardWrite", "geolocation", "notifications"], be one of ["accountsRead"], be one of ["addressBooks"], be one of ["compose"], be one of ["messagesModify"], be one of ["accountsFolders"], be one of ["messagesMove", "messagesRead"], be one of ["pkcs11"], be one of ["tabs", "tabHide"], be one of ["browserSettings"], be one of ["downloads", "downloads.open"], be one of ["management"], be one of ["privacy"], be one of ["proxy"], or be one of ["webNavigation"]], be one of ["alarms", "mozillaAddons", "storage", "unlimitedStorage"], be one of ["geckoProfiler"], be one of ["identity"], be one of ["menus"], be one of ["contextualIdentities"], be one of ["dns"], be one of ["activityLog"], be one of ["networkStatus"], be one of ["telemetry"], or be one of ["theme"]], must either [must either [be one of ["idle"], be one of ["menus.overrideContext"], be one of ["activeTab"], be one of ["cookies"], or be one of ["webRequest", "webRequestBlocking"]], be one of ["clipboardRead", "clipboardWrite", "geolocation", "notifications"], be one of ["accountsRead"], be one of ["addressBooks"], be one of ["compose"], be one of ["messagesModify"], be one of ["accountsFolders"], be one of ["messagesMove", "messagesRead"], be one of ["pkcs11"], be one of ["tabs", "tabHide"], be one of ["browserSettings"], be one of ["downloads", "downloads.open"], be one of ["management"], be one of ["privacy"], be one of ["proxy"], or be one of ["webNavigation"]], be one of ["nativeMessaging"], or match the pattern /^experiments(\\.\\w+)+$/], or must either [be one of ["<all_urls>"], must either [match the pattern /^(https?|wss?|file|ftp|\\*):\\/\\/(\\*|\\*\\.[^*/]+|[^*/]+)\\/.*$/, or match the pattern /^file:\\/\\/\\/.*$/], or match the pattern /^resource:\\/\\/(\\*|\\*\\.[^*/]+|[^*/]+)\\/.*$|^about:/]"
[task 2020-12-05T11:57:20.242Z] 11:57:20     INFO -  "CONSOLE_MESSAGE: (info) Treating warning as error because the preference extensions.webextensions.warnings-as-errors is set to true"
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "Warning processing permissions: Error processing permissions.0: Value "browsingData" must either: must either [must either [must either [must either [be one of ["idle"], be one of ["menus.overrideContext"], be one of ["activeTab"], be one of ["cookies"], or be one of ["webRequest", "webRequestBlocking"]], be one of ["clipboardRead", "clipboardWrite", "geolocation", "notifications"], be one of ["accountsRead"], be one of ["addressBooks"], be one of ["compose"], be one of ["messagesModify"], be one of ["accountsFolders"], be one of ["messagesMove", "messagesRead"], be one of ["pkcs11"], be one of ["tabs", "tabHide"], be one of ["browserSettings"], be one of ["downloads", "downloads.open"], be one of ["management"], be one of ["privacy"], be one of ["proxy"], or be one of ["webNavigation"]], be one of ["alarms", "mozillaAddons", "storage", "unlimitedStorage"], be one of ["geckoProfiler"], be one of ["identity"], be one of ["menus"], be one of ["contextualIdentities"], be one of ["dns"], be one of ["activityLog"], be one of ["networkStatus"], be one of ["telemetry"], or be one of ["theme"]], must either [must either [be one of ["idle"], be one of ["menus.overrideContext"], be one of ["activeTab"], be one of ["cookies"], or be one of ["webRequest", "webRequestBlocking"]], be one of ["clipboardRead", "clipboardWrite", "geolocation", "notifications"], be one of ["accountsRead"], be one of ["addressBooks"], be one of ["compose"], be one of ["messagesModify"], be one of ["accountsFolders"], be one of ["messagesMove", "messagesRead"], be one of ["pkcs11"], be one of ["tabs", "tabHide"], be one of ["browserSettings"], be one of ["downloads", "downloads.open"], be one of ["management"], be one of ["privacy"], be one of ["proxy"], or be one of ["webNavigation"]], be one of ["nativeMessaging"], or match the pattern /^experiments(\\.\\w+)+$/], or must either [be one of ["<all_urls>"], must either [match the pattern /^(https?|wss?|file|ftp|\\*):\\/\\/(\\*|\\*\\.[^*/]+|[^*/]+)\\/.*$/, or match the pattern /^file:\\/\\/\\/.*$/], or match the pattern /^resource:\\/\\/(\\*|\\*\\.[^*/]+|[^*/]+)\\/.*$|^about:/]" {file: "resource://gre/modules/Schemas.jsm" line: 1243}]
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  logWarning@resource://gre/modules/Schemas.jsm:1243:17
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  normalize@resource://gre/modules/Schemas.jsm:2225:16
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  checkProperty/r<@resource://gre/modules/Schemas.jsm:1906:16
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  withPath@resource://gre/modules/Schemas.jsm:603:14
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  checkProperty@resource://gre/modules/Schemas.jsm:1905:25
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  normalize@resource://gre/modules/Schemas.jsm:1978:14
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  normalize@resource://gre/modules/Schemas.jsm:3421:23
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  normalize@resource://gre/modules/Schemas.jsm:3611:28
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  _getNormalizedManifest@resource://gre/modules/Extension.jsm:879:20
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  parseManifest@resource://gre/modules/Extension.jsm:929:33
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:239:6
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:568:5
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  @-e:1:1
[task 2020-12-05T11:57:20.247Z] 11:57:20     INFO -  "

Must be from bug 1625233 ```

Comment 1

[Magnus Melin [:mkmelin]]

Bug 1625233 moved the tests from browser to toolkit, and added a ExtensionBrowsingData.jsm impl for android. But Thunderbird doesn't have have ExtensionBrowsingData.jsm, and I don't know if it's very useful for Thunderbird since there's not really browsing that we do.
If we do want it, we can probably just copy over Firefox impl

https://searchfox.org/comm-central/search?q=ExtensionBrowsingData.jsm&path=

Comment 2

[Intermittent Failures Robot]

48 failures in 3712 pushes (0.013 failures/push) were associated with this bug in the last 7 days.

This is the #23 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 48

Platform breakdown:

• linux64: 8
• linux64-shippable: 4
• windows7-32-shippable: 4
• windows7-32: 8
• macosx1014-64: 8
• windows10-64-shippable: 4
• windows10-64: 8
• macosx1014-64-shippable: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1680900&startday=2020-11-30&endday=2020-12-06&tree=all

Comment 3

[John Bieling (:TbSync)]

Having the option to clear cookie data might be useful. But we have to implement a dummy anyhow to get the test working again, or request m-c to exclude the test for thunderbird. If no one is opposing, I will go and add a ExtensionBrowsingData.jsm for us.

Comment 4

[Intermittent Failures Robot]

24 failures in 691 pushes (0.035 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 24

Platform breakdown:

• linux64: 4
• linux64-shippable: 2
• macosx1014-64: 4
• macosx1014-64-shippable: 2
• windows7-32: 4
• windows10-64: 4
• windows7-32-shippable: 2
• windows10-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1680900&startday=2020-12-07&endday=2020-12-07&tree=all

Comment 5

[John Bieling (:TbSync)]

Attachment: bug1680900_clone_browsingData_API.patch

Comment 6

[John Bieling (:TbSync)]

try c-c:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=399b02ca84acbc38490a750ee11b78528df9f19c

Comment 7

[John Bieling (:TbSync)]

Comment on attachment 9191836 [details] [diff] [review]
bug1680900_clone_browsingData_API.patch

Looks good on try.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9191836 [details] [diff] [review]
bug1680900_clone_browsingData_API.patch

Review of attachment 9191836 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/extensions/moz.build
@@ +6,5 @@
>      "extensions-mail.manifest",
>  ]
>  
>  EXTRA_JS_MODULES += [
> +    "../../../../browser/components/extensions/ExtensionBrowsingData.jsm",

We don't reference browser/ stuff in Thunderbird. You'll have to create a copy under mail/
Only toolkit/ things can be directly referenced.

Comment 9

[Geoff Lankow (:darktrojan)]

(In reply to Magnus Melin [:mkmelin] from comment #8)

We don't reference browser/ stuff in Thunderbird. You'll have to create a
copy under mail/
Only toolkit/ things can be directly referenced.

Yes we do and we should. If they have something that is exactly what we need, why should we maintain our own copy of it?

Comment 10

[Magnus Melin [:mkmelin]]

I would say those are bugs. Because, like I said, if it's browser/ it's Firefox only by design - if not it would be in toolkit/.

Comment 11

[John Bieling (:TbSync)]

Attachment: bug1680900_clone_browsingData_API_v2.patch

try on c-c:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=8c26112def8ad4ba6b62c195cb9fcdafd3ad26c4

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9192142 [details] [diff] [review]
bug1680900_clone_browsingData_API_v2.patch

Review of attachment 9192142 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, r=mkmelin

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2ef1c9d07fc1
clone browsingData API for Thunderbird. r=mkmelin

Comment 14

[Intermittent Failures Robot]

44 failures in 4060 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

This is the #19 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 44

Platform breakdown:

• linux64: 8
• linux64-shippable: 5
• macosx1014-64: 8
• macosx1014-64-shippable: 4
• windows7-32: 7
• windows10-64: 6
• windows7-32-shippable: 3
• windows10-64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1680900&startday=2020-12-07&endday=2020-12-13&tree=all