1680906 - Update Baidu（百度） logo to new icon

Status: VERIFIED FIXED

(Firefox :: Search, defect, P2)

Description

[Gakki]

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:68.0) Gecko/68.0 Firefox/68.0

Steps to reproduce:

Go to https://www.baidu.com, look at the icon.

Actual results:

It was an old icon in Search Engine setting .

new & old: https://i.imgur.com/dxUwRmR.png

Expected results:

Firefox should update to the new icon (2017. 10 - )

ico: https://www.baidu.com/favicon.ico
svg: https://www.baidu.com/img/baidu_85beaf5496f291521eb75ba38eacbd87.svg

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Mark Banner (:standard8)]

Thank you for the report, we're looking into this.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1680906 - Update Baidu search engine logo. r?mkaply!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19b578a77aae
Update Baidu search engine logo. r=mkaply

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/19b578a77aae

Comment 6

[Gakki]

(In reply to Mark Banner (:standard8) from comment #2)

Thank you for the report, we're looking into this.

Thank you for your reply, but this fix isn't correct. We should use this img : https://www.baidu.com/favicon.ico

You can try add Baidu engine from Opensearch.xml.

Preview: https://i.loli.net/2020/12/25/vrBQ358xC2RgEMe.png

Comment 7

[Dão Gottwald [:dao]]

Presumably we should just copy browser/components/newtab/data/content/tippytop/favicons/baidu-com.ico here.

Comment 8

[Mark Banner (:standard8)]

For the logo I received to use, it was implied that the logo to use came from Baidu directly. However, when I get back in the New Year, I'll re-confirm with the relevant people about the correct logo to use.

Comment 9

[Mark Banner (:standard8)]

We've double checked with Baidu, and they have definitely asked us to use the darker blue logo.

Comment 10

[Dão Gottwald [:dao]]

This means we now ship two different Baidu icons.

Comment 11

[Mark Banner (:standard8)]

(In reply to Dão Gottwald [::dao] from comment #10)

This means we now ship two different Baidu icons.

Thanks for the reminder, I've filed bug 1685310 to handle updating that one.

Comment 12

[Petruta Horea [:phorea], PTO until 8/22/25]

Verified as fixed using latest Nightly 86.0a1 under Win 10 64-bit and Ubuntu 18.04 64-bit.

Comment 13

[Gakki]

I regret that I opened this bug

I shoot myself in the foot, I screwed it up

in my opinion, the icon of search engine, It can only be favicon , I don't know why you're doing this above.

Can you offer an exception (other engines) ？

Can you offer a Baidu's website use this icon？

YOU CAN'T

Comment 14

[Gakki]

Now, there have a bug. You can turn a blind eye

IF I ADD BAIDU from 3-dot menu in address bar.

Baidu' icon are different, hahahha

You know, you guys are geniuses.

Comment 15

[Gakki]

Salute You

https://i.loli.net/2021/01/07/FPKCX6wL4Zm1DlM.png

Comment 16

[Gakki]

Just like the sh*t in dark mode, right ?

https://i.loli.net/2021/01/07/JOpQy4FxIhW5zda.png

Comment 17

[Mark Banner (:standard8)]

We have asked Baidu what to do. Baidu have asked us to use the darker icon. Whilst I agree this is different to the favicon they post, we are bound by what the partner themselves asks us to use.

Please note that your comments are in violation of our etiquette. Please re-read that before posting again.

Comment 18

[Mark Banner (:standard8)]

Comment on attachment 9194559 [details]
Bug 1680906 - Update Baidu search engine logo. r?mkaply!

Beta/Release Uplift Approval Request

• User impact if declined: Update of partner icons.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1685310
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small changes to icons for UI. Needs to uplift with bug 1685310 which included a fix for dark mode.
• String changes made/needed: None

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Update of partner icons.
• User impact if declined:
• Fix Landed on Version: 86 nightly
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Icon-only changes to UI. Needs to uplift with bug 1685310 which included a fix for dark mode.
• String or UUID changes made by this patch: None

Comment 19

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9194559 [details]
Bug 1680906 - Update Baidu search engine logo. r?mkaply!

approved for 85.0b9

Comment 20

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3d16118ff8ae

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9194559 [details]
Bug 1680906 - Update Baidu search engine logo. r?mkaply!

Approved for 78.7esr.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/34765f62d7d8

Comment 23

[Petruta Horea [:phorea], PTO until 8/22/25]

Verified as fixed using Firefox 85 beta 9 zh-CN locale under Win 10 64-bit and Ubuntu 18.04 64-bit.

Comment 24

[Petruta Horea [:phorea], PTO until 8/22/25]

Verified as fixed on Firefox 78.7esr.