1685310 - Update Baidu top site icon to the new Baidu version

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task, P2)

Description

[Mark Banner (:standard8)]

In bug 1680906 we swapped the search engine to the new Baidu logo. We were advised to use the slightly darker icon that's seen on the website not the favicon.

We should update the top site to use the same version of the logo.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1685310 - Update Top Sites icons for new version of Baidu logo. r?dao!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/facbcc4306d1
Update Top Sites icons for new version of Baidu logo. r=dao

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/facbcc4306d1

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 9195673 [details]
Bug 1685310 - Update Top Sites icons for new version of Baidu logo. r?dao!

Beta/Release Uplift Approval Request

• User impact if declined: Update of partner icons.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1680906
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small changes to icons for UI. Needs to uplift with bug 1685310 which included a fix for dark mode.
• String changes made/needed: None

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Update of partner icons.
• User impact if declined:
• Fix Landed on Version: 86 nightly
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small changes to icons for UI. Needs to uplift with bug 1685310 which included a fix for dark mode.
• String or UUID changes made by this patch: None

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9195673 [details]
Bug 1685310 - Update Top Sites icons for new version of Baidu logo. r?dao!

approved for 85.0b9

Comment 6

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9852bddf5384

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9195673 [details]
Bug 1685310 - Update Top Sites icons for new version of Baidu logo. r?dao!

Approved for 78.7esr.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/6629359693ce

Comment 9

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 85 beta 9 and latest Nightly 86.0a1 under Win 10 64-bit and Ubuntu 18.04 64-bit.