1681002 - Callback during verifyLogon() may throw exception into C++ Gecko

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[David Ward]

Noticed by :BenB during a code review involving changes to verifyLogin():

This function is also called from tryNextLogon(), where it's called twice. This caller has no logger attached, and worse, it doesn't even have a try/catch. It would throw into onStopRunningUrl(), which throws the exception into C++ Gecko. Not good.

Filing this as a separate bug (partly because the revised patch is no longer related to the original bug).

Comment 1

[David Ward]

Attachment: Bug 1681002 - Catch exception in OnStopRunningUrl() callback during verifyLogon(). r=BenB

Also, simplify the logging of exceptions caught during verifyConfig().

Comment 2

[Ben Bucksch (:BenB)]

Thank you!
r=BenB

Comment 3

[Ben Bucksch (:BenB)]

Once you completed testing (see Phab), you can set keyword checkin-needed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/18131ca2cd00
Catch exception in OnStopRunningUrl() callback during verifyLogon(). r=BenB,mkmelin