1681012 - Directly use XDR buffer from decoded stencil

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

As a preparation for directly using pinned data from decoded stencil, using XDR buffer directly from decoded stencil will help decoding performance.
It requires the following:

• Add alignment requirement for TranscodeRange and TranscodeBuffer, when encoding and decoding, so that the content can be aligned to 32-bit etc boundary
• Add lifetime requirement for TranscodeRange and TranscodeBuffer, when decoding, in order to make the underlying XDR buffer alive while decoded stencil is alive
• when encoding/decoding, align before each 32-bit etc field that is directly referred from decoded stencil

Comment 1

[Tooru Fujisawa [:arai]]

filed bug 1681304 and bug 1681308 because they'll affect API consumer.

Comment 2

[Tooru Fujisawa [:arai]]

TODO:

• assert the alignment of those structs is 4 bytes or less, in StencilXdr.cpp
  • this will also assert that those structs don't contain pointers, on 64-bit arch

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1681012 - Part 1: Add align32 method. r?nbp!

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1681012 - Part 2: Align before main buf. r?nbp!

Depends on D101429

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1681012 - Part 3: Align before span and scope data and atom. r?nbp!

Depends on D101430

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1681012 - Part 4: Directly use XDR buffer from decoded stencil. r?nbp!

Depends on D101431

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e86358ebe06
Part 1: Add align32 method. r=nbp
https://hg.mozilla.org/integration/autoland/rev/94306219bca3
Part 2: Align before main buf. r=nbp
https://hg.mozilla.org/integration/autoland/rev/bb1260eb0986
Part 3: Align before span and scope data and atom. r=nbp
https://hg.mozilla.org/integration/autoland/rev/1aff06604426
Part 4: Directly use XDR buffer from decoded stencil. r=nbp

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0e86358ebe06
https://hg.mozilla.org/mozilla-central/rev/94306219bca3
https://hg.mozilla.org/mozilla-central/rev/bb1260eb0986
https://hg.mozilla.org/mozilla-central/rev/1aff06604426

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0e86358ebe06
https://hg.mozilla.org/mozilla-central/rev/94306219bca3
https://hg.mozilla.org/mozilla-central/rev/bb1260eb0986
https://hg.mozilla.org/mozilla-central/rev/1aff06604426