1681308 - Add alignment requirement for TranscodeRange and TranscodeBuffer

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

To directly use XDR buffer from decoded stencil data, buffer+cursor and range passed to the following should align to 4 bytes:

• DecodeOffThreadScript
• EncodeScript
• DecodeScript
• DecodeScriptMaybeStencil
• DecodeScriptAndStartIncrementalEncoding
• FinishIncrementalEncoding

Comment 1

[Tooru Fujisawa [:arai]]

currently ScriptLoader has 5 bytes or some data summary at the beginning of buffer
https://searchfox.org/mozilla-central/rev/ffdb6a4d934b3f5294f18cf0e1df618109ccb36b/dom/security/SRICheck.cpp#346-392

to align 32-bit, the consumer of transcoding API should add padding after that.

Comment 2

[Nicolas B. Pierron [:nbp] {away}]

(In reply to Tooru Fujisawa [:arai] from comment #1)

currently ScriptLoader has 5 bytes or some data summary at the beginning of buffer
https://searchfox.org/mozilla-central/rev/ffdb6a4d934b3f5294f18cf0e1df618109ccb36b/dom/security/SRICheck.cpp#346-392

Note, It has more than 5 bytes, it also contains the hash payload which size depends on the last script tag which recorded it.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1681308 - Add alignment requirement to XDR buffer. r?nbp!

Depends on D101124

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38a29b24d611
Add alignment requirement to XDR buffer. r=nbp

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/38a29b24d611