Closed Bug 1681048 Opened 3 years ago Closed 3 years ago

Drop support for search engines with a load path pointing to a distribution or language pack

Categories

(Firefox :: Search, task, P2)

task
Points:
3

Tracking

()

VERIFIED FIXED
85 Branch
Iteration:
85.2 - Nov 30 - Dec 13
Tracking Status
firefox85 --- verified

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

There are some search engines being reported via telemetry that have a load path that indicates they were originally from a distribution or language pack.

Language pack engines were moved to be part of the main Firefox application in Firefox 62. Distribution engines were moved in Firefox 79.

For these application provided engines, the load path is forced to be [other]addEngineWithDetails:<extension id>.

Hence there should not be any remaining distribution/language pack search engines remaining on the old mechanism. The most likely causes for some users being in this state is:

  • A user used to use a language pack with a search engine installed, but it got disabled on update, though we still (incorrectly) kept the search engine in the settings - and the default configuration did not have one of the same name. This can also affect distribution engines.
  • Some distributions are no longer supported, and hence should be reverted to the defaults.

In any case, these original methods of installation are no longer supported, so we want to get these users back onto supported configurations.

If an engine is default, the user will be reverted to the application/distribution default.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/858033ae6d59
Ensure obsolete distribution/langpack engines are dropped in the search service. r=daleharvey
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

I've managed to reproduce the issue using this build. When upgrading to a version that doesn't have the fix, the default search engine is still yahoo.

Marking the issue as verified using the latest Fx85.0a1 on windows 10 and macOS 10.15. The engine is completely removed from the search engine list.

Status: RESOLVED → VERIFIED
See Also: → 1688643
Blocks: 1688663
You need to log in before you can comment on or make changes to this bug.