1681171 - Report sandboxed iframes without navigation capabilities in external protocol handler telemetry

Status: RESOLVED FIXED

(Firefox :: Security, task, P3)

Description

[Johann Hofmann [:johannh]]

We'd like to make some updates to opening external protocols in iframes, so we should also key external_protocol_handler_dialog_context_scheme by sandboxed iframes without allow-top-navigation, allow-top-navigation-by-user-activation or allow-popups present.

Paul, would you like to take this? :)

Thanks!

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1681171 - Update external protocol handler telemetry probe to include sandboxed iframes. r=johannh

Comment 2

[Paul Zühlcke [:pbz]]

We're only extending the probe slightly to get more info about iframe sandbox properties. The data review from Bug 1672344 should cover this: https://bugzilla.mozilla.org/show_bug.cgi?id=1672344#c9

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/758b008e5ec6
Update external protocol handler telemetry probe to include sandboxed iframes. r=johannh

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/758b008e5ec6

Comment 5

[Johann Hofmann [:johannh]]

Can we get this uplifted? :)

Thanks!

Comment 6

[Paul Zühlcke [:pbz]]

Comment on attachment 9192227 [details]
Bug 1681171 - Update external protocol handler telemetry probe to include sandboxed iframes. r=johannh

Beta/Release Uplift Approval Request

• User impact if declined: Telemetry code, no direct user impact.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Doesn't change behavior for users. Small code change. Telemetry code is in a try-catch so we shouldn't break anything even if it throws.
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau] (back April 22)]

Can we verify we're getting the expected data from nightly before we uplift?

Comment 8

[Paul Zühlcke [:pbz]]

Sure! We can already see a handful of pings which have it: https://mzl.la/3oYIADW
The new keys are: SUB_SANDBOX_ALLOW and SUB_SANDBOX_NOALLOW.

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9192227 [details]
Bug 1681171 - Update external protocol handler telemetry probe to include sandboxed iframes. r=johannh

approved for 85.0b3

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c11ec811520