1681310 - Add a code path for batched texture uploads via glTexImage2D

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Nicolas Silva [:nical]]

Bug 1661528, introduced a batched texture upload mechanism using PBOs for ocnfigurations that havea high driver overhead per texture upload.

We also have this overhead on low-end Intel on Windows, however we use glTexSubImage2D to upload textures on this configuration so we need a bit of extra plumbing.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1681310 - Add a batched texture upload code path using glTexSubImage2D.

Our existing batched texture upload logic works with pixel buffer objects which we don't use with ANGLE.
The motivation is to avoid expensive driver overhead from submitting many glTexSubImage2D calls (one for each texture cache item) on low-end Intel Windows configurations.

On Windows+Intel it is much faster to use batched draw calls to copy from staging textures to texture cache than using CopySubResourceRegion (when there is a high number of copies).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/067757947538
Add a batched texture upload code path using glTexSubImage2D. r=jnicol

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/067757947538