16814 - [DOGFOOD] All attached image files that surpasses 8k in size can not be viewd after received

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[marina]

I was experimenting with attaching image files to New Mail, the one that was 7K
came up Ok, the other ones (8K, 9K, 13K) came empty. There was a bug that was
fixed (and i haven't had a problem today) # 14612 : apprunner crashes when
attaching html files bigger then 8K.
**** observed with 1999-10-19-09-M11 Win build****

Comment 1

[Phil Peterson]

Reassign to mscott, cc jefft. Sounds like something you guys were just working
on.

Comment 2

[Scott MacGregor]

marina, was this for imap or pop? I've fixed a couple problems related to this

last week but it sounds like you are seeing it this week. with this morning's

build. hmm.

Comment 3

[marina]

Yes, forgot to mention, both IMAP and POP are having this problem.

Comment 4

[Scott MacGregor]

Can you try again today? I made some changes to fix another bug that may effect
this problem.

Also, I still haven't been able to reproduce this problem. I have messages with
3 or 4 embedded images in them and I'm able to see them in the message pane.
Although it does seem to take a while. I'm still trying to reproduce this.

This is certainly a dogfood bug. marking as such.

Comment 5

[Scott MacGregor]

In trying to view some more images over and over again, I found that every now
and then one of them would fail to load. I tracked this down to a fence post
condition in nsMsgLineStreamBuffer::ReadNextLine tha caused the imap protocol to
block if we had 1 byte free in the stream buffer and 1 byte left in the stream
from the incoming server. A rare case but one that did cause a hang.

I'm going to go ahead and mark this as fixed. Marina, can you run through some
of the image files that were causing you problems with 10/21 or later builds?
Thanks!

Comment 6

[marina]

Yes, i'll do it with 10/21 build because the today's one is very bad anyway and
i'm still running on the same problem.

Comment 7

[marina]

While was looking at this bug discovered one more thing:
even when image is less then 8K( 7K in my case) and is coming attached just fine
after you click reply it disppears from the body.

Comment 8

[Scott MacGregor]

I noticed this fact to. I just filed Bug #16927 to track the fact that the
image isn't showing up in the message body when you reply to a message.

Comment 9

[pmock]

changing QA assigned to myself

Comment 10

[marina]

I'm having the same problem again with 1999-11-10 Win build, i'm not able to
neither attach an image  file nor insert it. When inserting it gives me an error
message :" the number you entered (o) is outside of allowed range.Please enter
the number between 1 and 10000". I'm reopening

Comment 11

[pmock]

cleaning resolution

Comment 12

[leger]

Putting on PDT+ radar.

Comment 13

[Phil Peterson]

M12 fix apparently not imminent.

Comment 14

[jefft]

marina, were you trying to insert image into the editor? If it is then that's
editor's problem not mail/news problem. Using Attach button from the mail
compose window is fine. You might be confused with attching image attachments vs
inserting images into html editor. Regarding images surpasses 8k, I believe we
do have the corruption problem which is addressed in bug 10232.

Comment 15

[marina]

I reopened this bug based on those testing results:
1)attaching an image (open new mail|click attach|choose image file from the
local);
2) i have several gif files: one is 9k and the other one is 4k;
3)viewing the 4k attachment is no problem;
4)viweing the 9k attachment gives me "inbox?number=3744607&part=1" instead of
image itself;
The insertion operation (Insert an image into the mail body by going
(Insert|Image) might belong to Editor but is problamatic also (in the same way i
described the attachment problem)

Comment 16

[jefft]

Warren has fixed the problem. Reassign to warren to mark it fixed.

Comment 17

[Warren Harris]

Fix checked in.

Comment 18

[pmock]

Verified as fixed on win, mac, and linux using the following builds:
ftp://sweetlou/products/client/seamonkey/windows/32bit/x86/1999-11-18-09-M12/sea
monkey32.exe
ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/1999-11-17-08-M12/netscap
e5-mac-M11.sea.bin
ftp://sweetlou/products/client/seamonkey/unix/linux_glibc/2.2/x86/1999-11-17-17-
M12/netscape-i686-pc-linux-gnu.tar.gz

Comment 19

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/53e146637b73
[fenix] Create new android-test-beta build (https://github.com/mozilla-mobile/fenix/pull/16814)