1681421 - Implement new Proton tab design

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The goal here is to do a rough implementation and see what performance issues we may encounter or difficulties in implementing.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1681421 - Prototype new Proton tab design.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1681421 - Implement separated Proton tab design behind browser.proton.enabled pref.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1681421 - Use the new BrowserTestUtils method to clear the XUL cache.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Review ping?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b649f963a6b1
Implement separated Proton tab design behind browser.proton.enabled pref. r=dao,Gijs,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/b4556b1e292c
Use the new BrowserTestUtils method to clear the XUL cache. r=Gijs

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_devtools-record-capture.js

backout: https://hg.mozilla.org/integration/autoland/rev/3854602a8cd25f3aea70b43204b99e8d5abd026f

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=b4556b1e292c2b8e9d3673a06490711bf54f8ea0&searchStr=devtools&selectedTaskRun=MxM-pghwS4W5LV1eo69jrQ.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=327271103&repo=autoland&lineNumber=3488

[task 2021-01-20T18:04:54.800Z] 18:04:54 INFO - Buffered messages logged at 18:04:53
[task 2021-01-20T18:04:54.801Z] 18:04:54 INFO - > Waiting for the fake frontend tab to be loaded. (After 988 seconds)
[task 2021-01-20T18:04:54.801Z] 18:04:54 INFO - Buffered messages finished
[task 2021-01-20T18:04:54.802Z] 18:04:54 INFO - TEST-UNEXPECTED-FAIL | devtools/client/performance-new/test/browser/browser_devtools-record-capture.js | Test timed out -
[task 2021-01-20T18:04:54.802Z] 18:04:54 INFO - GECKO(1542) | MEMORY STAT | vsize 3250MB | residentFast 516MB | heapAllocated 224MB
[task 2021-01-20T18:04:54.803Z] 18:04:54 INFO - TEST-OK | devtools/client/performance-new/test/browser/browser_devtools-record-capture.js | took 990031ms
[task 2021-01-20T18:04:54.804Z] 18:04:54 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-01-20T18:04:54.804Z] 18:04:54 INFO - TEST-UNEXPECTED-FAIL | devtools/client/performance-new/test/browser/browser_devtools-record-capture.js | Found a tab after previous test timed out: http://example.com/browser/devtools/client/performance-new/test/browser/fake-frontend.html -
[task 2021-01-20T18:04:54.805Z] 18:04:54 INFO - Not taking screenshot here: see the one that was previously logged

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1681421 - Read the label property instead of textContent to exclude hidden text.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ad888360159
Implement separated Proton tab design behind browser.proton.enabled pref. r=dao,Gijs,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/299ed5ca5fee
Use the new BrowserTestUtils method to clear the XUL cache. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/d6026fdaa6aa
Read the label property instead of textContent to exclude hidden text. r=mstange

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1ad888360159
https://hg.mozilla.org/mozilla-central/rev/299ed5ca5fee
https://hg.mozilla.org/mozilla-central/rev/d6026fdaa6aa

Comment 10

[Negritas Sergiu, Desktop QA]

Hello I have managed to reproduce the issue with Fx 85.0a1 (2020-12-08) and I can confirm that the issue is fixed with fx 86.0a1 (2021-01-21) and with fx 88.0a1 (2021-03-16). I will mark this issue accordingly.

Thank you!

Comment 11

[dlukyanov]

Is it possible to know why tab_background_separator property has been deprecated?
There are so many claims over the internet that it's impossible to see borders of tabs in firefox...