Deprecate tab_background_separator property in Firefox 89
Categories
(WebExtensions :: Themes, task, P2)
Tracking
(Not tracked)
People
(Reporter: caitmuenster, Unassigned)
References
Details
The tab_background_separator line will not be supported in Firefox versions 89+, per conversation with jaws. We should mark this property as deprecated in Firefox.
|
||
Comment 1•3 years ago
|
||
The property became obsolete for Proton in bug 1681421.
For the deprecation, we need to add "deprecated" to https://searchfox.org/mozilla-central/rev/4648b6ee31c2519b1753023e4f4853b14fdd16e5/toolkit/components/extensions/schemas/theme.json#131 .
The property is still present in the code because non-Proton uses it, as explained at https://github.com/mozilla/FirefoxColor/issues/969#issuecomment-827888032 . Not part of this bug, but we should probably remove references to it in the stylesheet (tabs.inc.css), ext-theme.js and ThemeVariableMap.jsm in the future.
|
|
||
Updated•3 years ago
|
|
Reporter | |
Comment 2•3 years ago
|
||
I am interested in working on this bug. :)
|
|
||
Comment 3•3 years ago
|
||
(In reply to Caitlin Neiman [:caitmuenster] from comment #2)
I am interested in working on this bug. :)
This bug is available. Feel free to work on this bug. To get started, see comment 1 and https://wiki.mozilla.org/WebExtensions/Contribution_Onramp
FYI: The last remaining test that uses this property was removed in https://phabricator.services.mozilla.com/D115748. So even if you only change the code, all existing unit tests will pass.
To check whether your proposed change works as expected, create a theme extension* and load it at about:debugging. With the patch, you should see an error in the Browser Console - https://developer.mozilla.org/en-US/docs/Tools/Browser_Console
* Here is an example of a dynamic theme that you can adapt: https://github.com/mdn/webextensions-examples/tree/master/dynamic-theme
To create a static theme (a manifest.json file, you can see the existing examples at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme), or even simply use Firefox Color and export a theme (https://color.firefox.com/ ).
(In reply to Caitlin Neiman [:caitmuenster] from comment #0)
The tab_background_separator line will not be supported in Firefox versions 89+, per conversation with jaws. We should mark this property as deprecated in Firefox.
Is it possible to know why this property has been deprecated?
There are so many claims over the internet that it's impossible to see borders of firefox tabs since version 89
|
|
Reporter | |
Comment 5•3 years ago
|
||
(In reply to dlukyanov from comment #4)
Is it possible to know why this property has been deprecated?
There are so many claims over the internet that it's impossible to see borders of firefox tabs since version 89
I've heard a lot of that feedback, and I hope we can set those folks up with something to help them differentiate tabs. A couple of teams within Firefox came together to collaboratively make the decision to refresh the visual appearance of Firefox, and deprecating this property was part of that decision.
Wow! Thank you very much for response!!! (really)
Could you please provide any details on what should replace this property in case when people want see the border?
Maybe there is a workaround to make border visible with themes, styles, ...?
Maybe someone from guru could suggest on how to make a theme with borders around the tab - i'm loosing my eyes.
Thank you in advance!
|
|
Reporter | |
Comment 7•3 years ago
|
||
Sorry, the best workaround at the moment would be to find or make a theme that shows high contrast between the active tab and the inactive tabs. There's currently no way to restore the border separators. We've got a couple of patches in Firefox to hopefully increase the contrast between active and inactive tabs.
Since this is a bug tracker and not a support forum, I would recommend reaching out to the community on our forum at https://discourse.mozilla.org/c/add-ons/themes to continue the conversation. :)
Description
•