1681426 - Startup Crash in [@ core::option::expect_none_failed | xulstore::statics::get_database]

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Crash report: https://crash-stats.mozilla.org/report/index/291bace9-0b2b-4a2c-a66f-b88b70201208

MOZ_CRASH Reason: called `Result::unwrap()` on an `Err` value: DatabaseCorrupted

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:16
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 xul.dll core::ops::function::Fn::call<fn ../7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/ops/function.rs:227
3 xul.dll std::panicking::rust_panic_with_hook ../7eac88abb2e57e752f3302f02be5f3ce3d7adfb4//library/std/src/panicking.rs:581
4 xul.dll std::panicking::begin_panic_handler::{{closure}} ../7eac88abb2e57e752f3302f02be5f3ce3d7adfb4//library/std/src/panicking.rs:484
5 xul.dll std::sys_common::backtrace::__rust_end_short_backtrace<closure-0, !> ../7eac88abb2e57e752f3302f02be5f3ce3d7adfb4//library/std/src/sys_common/backtrace.rs:153
6 xul.dll std::panicking::begin_panic_handler ../7eac88abb2e57e752f3302f02be5f3ce3d7adfb4//library/std/src/panicking.rs:483
7 xul.dll core::panicking::panic_fmt ../7eac88abb2e57e752f3302f02be5f3ce3d7adfb4//library/core/src/panicking.rs:85
8 xul.dll core::option::expect_none_failed ../7eac88abb2e57e752f3302f02be5f3ce3d7adfb4//library/core/src/option.rs:1234
9 xul.dll xulstore::statics::get_database toolkit/components/xulstore/src/statics.rs:49

Comment 1

[Victor Porof [:vporof][:vp]]

DatabaseCorrupted is a result only occurring when lmdb::Error::Corrupted is received, and bug 1654192 should have removed all traces of LMDB. Investigating.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1681426 - Enable 'no-canonicalize-path' for xulstore, r=nanj

Comment 3

[Victor Porof [:vporof][:vp]]

I've also noticed some crashes when migrating kvstore to use Managers earlier this summer, which seem to be the same issue as bug 1531887. I don't know if that's the cause of this particular crash as well, but xulstore wasn't using Manager before either.

Another thing that might fix this is bug 1681492, which vendors in https://github.com/mozilla/rkv/pull/211

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06e7aa9b7420
Enable 'no-canonicalize-path' for xulstore, r=nanj

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/06e7aa9b7420