Closed Bug 1654192 Opened 4 years ago Closed 4 years ago

Use RKV safe mode for xulstore

Categories

(Toolkit :: Storage, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(3 files)

No description provided.
Blocks: 1637680
No longer blocks: 1637680
See Also: → 1597898
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Pushed by vporof@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1ee7be3a135
Part 1: Update RKV dependency to safe-mode, r=nanj
https://hg.mozilla.org/integration/autoland/rev/885b9b821bc0
Part 2: Update xulstore to use RKV in safe mode, r=nanj
Flags: needinfo?(vporof)
Pushed by vporof@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6657944c0b63
Part 1: Update RKV dependency to safe-mode, r=nanj
https://hg.mozilla.org/integration/autoland/rev/bad6faf26935
Part 2: Update xulstore to use RKV in safe mode, r=nanj

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:vporof, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(vporof)
Severity: -- → S3
Priority: -- → P3

Back on it now.

Flags: needinfo?(vporof)

(In reply to Dorel Luca [:dluca] from comment #6)

Backed out 2 changesets (bug 1654192) for Talos failures in \xulstore\data.safe.bin. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311666256&repo=autoland&lineNumber=1748

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=bad6faf26935ebcc07e602769e43286ddd5d183a

Backout:
https://hg.mozilla.org/integration/autoland/rev/2038f000aed1471bb91ff711cabb3e32b7982279

:dluca, is there any way I can see that this patch no longer causes the failures before it was backed out? If there's a push to try please guide :vporof through that.

Flags: needinfo?(dluca)
Flags: needinfo?(aionescu)

Seems like the push is failing talos slightly different from the previous \xulstore\data.mdb
https://treeherder.mozilla.org/jobs?repo=try&revision=4c53597c41c86e4de8f0a16f23998375fb2a7cf8&searchStr=talos

Flags: needinfo?(aionescu) → needinfo?(vporof)

Right, bizarre that didn't show up in my try run.

So what's happening is that we've transitioned to using a different storage backend, and therefore a one-time migration needs to happen before the data can be accessed. In other words, we went from '\xulstore\data.mdb' to the newly added '\xulstore\data.safe.bin'.

We plan to remove the old storage backend fairly soon in the future. But even if we don't, to be clear, the old data is accessed only one for the one-time migration. And it won't happen if there's no 'data.mdb' available (which is the case for users on release – this has only been running in nightly and beta).

I would expect it's reasonable to keep the old '\xulstore\data.mdb' in 'xtalos/xperf_whitelist.json' in the meantime?

Flags: needinfo?(vporof) → needinfo?(aionescu)

I added them because your patches were backed out because of these intermittents so I wanted to make sure the reason why they were backed out is gone.
If you think that is reasonable and will get rid of the intermittents, go ahead.

Flags: needinfo?(aionescu)
Flags: needinfo?(aionescu)

I can see in the comments your question has been answered, removed NI as such.

Flags: needinfo?(dluca)
Flags: needinfo?(aionescu)
Pushed by vporof@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26abc175808e
Part 1: Update RKV dependency to safe-mode, r=nanj
https://hg.mozilla.org/integration/autoland/rev/a92f0deb07b2
Part 2: Update xulstore to use RKV in safe mode, r=nanj,perftest-reviewers,AlexandruIonescu
https://hg.mozilla.org/integration/autoland/rev/b09ca0548784
Part 3: Use manager instead of creating unique instances every time, r=nanj

Thanks! The error is isolated to bug 1680230, not this one, but the two should land simultaneously. On it!

Flags: needinfo?(vporof)
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54d791bb417b
Part 1: Update RKV dependency to safe-mode, r=nanj
https://hg.mozilla.org/integration/autoland/rev/16f75cdb5ea0
Part 2: Update xulstore to use RKV in safe mode, r=nanj,perftest-reviewers,AlexandruIonescu
https://hg.mozilla.org/integration/autoland/rev/15a3d7e84a53
Part 3: Use manager instead of creating unique instances every time, r=nanj
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

== Change summary for alert #28050 (as of Fri, 11 Dec 2020 05:44:11 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
2% startup_about_home_paint_realworld_webextensions startup_about_home_paint_realworld_webextensions linux64-shippable-qr e10s stylo webrender 843.92 -> 823.50
2% startup_about_home_paint_realworld_webextensions startup_about_home_paint_realworld_webextensions linux64-shippable-qr e10s stylo webrender 843.25 -> 826.08

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28050

Hey, 2% is 2%. Add that to the 4-7% from bug 1594995, at least it's something.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: