Closed Bug 1681495 Opened 4 years ago Closed 2 years ago

"Delete cookies and site data when Nightly is closed" should update sanitization prefs instead of network.cookie.lifetimePolicy

Categories

(Firefox :: Settings UI, task, P3)

task

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- wontfix
firefox103 --- fixed

People

(Reporter: johannh, Assigned: h.sofie.p)

References

Details

Attachments

(1 file)

As part of trying to get rid of network.cookie.lifetimePolicy we want to switch the "Delete cookies and site data when Nightly is closed" in about:preferences to flip sanitization prefs (privacy.clearOnShutdown.) instead.

Component: Networking: Cookies → Preferences
Product: Core → Firefox
Severity: -- → N/A

Hi! I'm an Outreachy applicant. I'm interested in taking this up. Can you provide me with some more details so that I can work on this bug?

Hi Anshul, I’m afraid this isn’t the best bug to work on as part of an Outreachy contribution. It’s part of a larger project. Thank you for your interest, though!

(In reply to Johann Hofmann [:johannh] from comment #2)

Hi Anshul, I’m afraid this isn’t the best bug to work on as part of an Outreachy contribution. It’s part of a larger project. Thank you for your interest, though!

Thanks for replying, Johann. I'm looking for a bug under "Preferences" component and found this. Is there any other bug I can work upon under this component? Thank you so much. :)

Assignee: nobody → hpeuckmann
See Also: → 1754924
Attachment #9266506 - Attachment description: WIP: Bug 1681495 - Switch clear cookies and site data checkbox to controll sanitization prefs. r=pbz! → Bug 1681495 - Switch clear cookies and site data checkbox to controll sanitization prefs. r=pbz!
Attachment #9266506 - Attachment description: Bug 1681495 - Switch clear cookies and site data checkbox to controll sanitization prefs. r=pbz! → Bug 1681495 - Switch clear cookies and site data checkbox to control sanitization prefs. r=pbz!
See Also: → 1764761

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hpeuckmann, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(pbz)
Flags: needinfo?(hpeuckmann)

This patch was waiting on some dependent patches to be ready to be able to land. Paul and I had a discussion about this today, the patch will be landed soon.

Flags: needinfo?(hpeuckmann)
Pushed by hpeuckmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c553d7f2e586 Switch clear cookies and site data checkbox to control sanitization prefs. r=pbz

Backed out for causing marionette failures on test_service_worker_at_shutdown.py.

Push with failures

Failure log

Backout link

[task 2022-05-06T06:34:20.456Z] 06:34:20     INFO -  TEST-START | toolkit/components/cleardata/tests/marionette/test_service_worker_at_shutdown.py ServiceWorkerAtShutdownTestCase.test_unregistering_service_worker_when_clearing_data
[task 2022-05-06T06:34:20.456Z] 06:34:20     INFO -  1651818860457	Marionette	DEBUG	Accepted connection 81 from 127.0.0.1:54565
[task 2022-05-06T06:34:20.484Z] 06:34:20     INFO -  1651818860485	Marionette	DEBUG	81 -> [0,1,"WebDriver:NewSession",{"strictFileInteractability":true}]
[task 2022-05-06T06:34:20.488Z] 06:34:20     INFO -  1651818860488	RemoteAgent	TRACE	[66] Document already finished loading: http://127.0.0.1:49931/layout/test_carets_iframe_scroll.html
[task 2022-05-06T06:34:20.489Z] 06:34:20     INFO -  1651818860489	Marionette	DEBUG	81 <- [1,1,null,{"sessionId":"ad36d4e9-da42-4771-b6a3-6ea734ece6c1","capabilities":{"browserName":"firefox","browserVersion":"102.0 ... 9.mozrunner","moz:shutdownTimeout":60000,"moz:useNonSpecCompliantPointerOrigin":false,"moz:webdriverClick":true,"proxy":{}}}]
[task 2022-05-06T06:34:20.490Z] 06:34:20     INFO -  1651818860490	Marionette	DEBUG	81 -> [0,2,"WebDriver:SetTimeouts",{"script":30000}]
[task 2022-05-06T06:34:20.490Z] 06:34:20     INFO -  1651818860490	Marionette	DEBUG	81 <- [1,2,null,{"value":null}]
[task 2022-05-06T06:34:20.491Z] 06:34:20     INFO -  1651818860491	Marionette	DEBUG	81 -> [0,3,"WebDriver:SetTimeouts",{"pageLoad":300000}]
[task 2022-05-06T06:34:20.491Z] 06:34:20     INFO -  1651818860492	Marionette	DEBUG	81 <- [1,3,null,{"value":null}]
[task 2022-05-06T06:34:20.492Z] 06:34:20     INFO -  1651818860493	Marionette	DEBUG	81 -> [0,4,"WebDriver:SetTimeouts",{"implicit":0}]
[task 2022-05-06T06:34:20.492Z] 06:34:20     INFO -  1651818860493	Marionette	DEBUG	81 <- [1,4,null,{"value":null}]
[task 2022-05-06T06:34:20.493Z] 06:34:20     INFO -  1651818860494	Marionette	DEBUG	81 -> [0,5,"WebDriver:Navigate",{"url":"http://127.0.0.1:49931/serviceworker/install_serviceworker.html"}]
[task 2022-05-06T06:34:20.494Z] 06:34:20     INFO -  [Parent 7012, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x804B0051 (NS_ERROR_HOST_IS_IP_ADDRESS): file /builds/worker/checkouts/gecko/toolkit/components/antitracking/URLQueryStringStripper.cpp:132
[task 2022-05-06T06:34:20.496Z] 06:34:20     INFO -  1651818860497	Marionette	TRACE	[66] Received event beforeunload for http://127.0.0.1:49931/layout/test_carets_iframe_scroll.html
[task 2022-05-06T06:34:20.509Z] 06:34:20     INFO -  1651818860510	Marionette	TRACE	Remoteness change detected. Set new top-level browsing context to 68
[task 2022-05-06T06:34:20.519Z] 06:34:20     INFO -  1651818860519	Marionette	TRACE	[68] Received event beforeunload for about:blank
[task 2022-05-06T06:34:20.523Z] 06:34:20     INFO -  1651818860523	Marionette	TRACE	[68] Received event pagehide for about:blank
[task 2022-05-06T06:34:20.537Z] 06:34:20     INFO -  1651818860545	Marionette	TRACE	[68] Received event DOMContentLoaded for http://127.0.0.1:49931/serviceworker/install_serviceworker.html
[task 2022-05-06T06:34:20.546Z] 06:34:20     INFO -  1651818860546	Marionette	TRACE	[68] Received event pageshow for http://127.0.0.1:49931/serviceworker/install_serviceworker.html
[task 2022-05-06T06:34:20.547Z] 06:34:20     INFO -  1651818860547	Marionette	DEBUG	81 <- [1,5,null,{"value":null}]
[task 2022-05-06T06:34:20.557Z] 06:34:20     INFO -  1651818860557	Marionette	DEBUG	81 -> [0,6,"Marionette:GetContext",{}]
[task 2022-05-06T06:34:20.558Z] 06:34:20     INFO -  1651818860558	Marionette	DEBUG	81 <- [1,6,null,{"value":"content"}]
[task 2022-05-06T06:34:20.560Z] 06:34:20     INFO -  1651818860560	Marionette	DEBUG	81 -> [0,7,"Marionette:SetContext",{"value":"chrome"}]
[task 2022-05-06T06:34:20.560Z] 06:34:20     INFO -  1651818860560	Marionette	DEBUG	81 <- [1,7,null,{"value":null}]
[task 2022-05-06T06:34:20.568Z] 06:34:20     INFO -  1651818860568	Marionette	DEBUG	81 -> [0,8,"WebDriver:ExecuteScript",{"script":"let serviceWorkerManager = Cc[\"@mozilla.org/serviceworkers/manager;1\"].getService ... 06\\build\\tests\\marionette\\tests\\toolkit\\components\\cleardata\\tests\\marionette\\test_service_worker_at_shutdown.py"}]
[task 2022-05-06T06:34:20.570Z] 06:34:20     INFO -  1651818860570	Marionette	TRACE	[14] MarionetteCommands actor created for window id 2
[task 2022-05-06T06:34:20.573Z] 06:34:20     INFO -  1651818860573	Marionette	DEBUG	81 <- [1,8,null,{"value":true}]
[task 2022-05-06T06:34:20.573Z] 06:34:20     INFO -  [Parent 7012, DOMCacheThread] WARNING: QM_TRY failure (WARNING): '"ToResult(file->Remove( false))" failed with resultCode 0x80520012, resultName NS_ERROR_FILE_NOT_FOUND', file dom/cache/FileUtils.cpp:775
[task 2022-05-06T06:34:20.574Z] 06:34:20     INFO -  1651818860574	Marionette	DEBUG	81 -> [0,9,"Marionette:SetContext",{"value":"content"}]
[task 2022-05-06T06:34:20.574Z] 06:34:20     INFO -  [Parent 7012, DOMCacheThread] WARNING: QM_TRY failure (WARNING): '"ToResult(file->Remove( false))" failed with resultCode 0x80520012, resultName NS_ERROR_FILE_NOT_FOUND', file dom/cache/FileUtils.cpp:775
[task 2022-05-06T06:34:20.574Z] 06:34:20     INFO -  1651818860574	Marionette	DEBUG	81 <- [1,9,null,{"value":null}]
[task 2022-05-06T06:34:20.575Z] 06:34:20     INFO -  1651818860575	Marionette	DEBUG	81 -> [0,10,"Marionette:GetContext",{}]
<...>
[task 2022-05-06T06:34:24.582Z] 06:34:24     INFO -  1651818864582	Marionette	DEBUG	2 -> [0,14,"Marionette:SetContext",{"value":"content"}]
[task 2022-05-06T06:34:24.582Z] 06:34:24     INFO -  1651818864582	Marionette	DEBUG	2 <- [1,14,null,{"value":null}]
[task 2022-05-06T06:34:24.592Z] 06:34:24    ERROR -  TEST-UNEXPECTED-FAIL | toolkit/components/cleardata/tests/marionette/test_service_worker_at_shutdown.py ServiceWorkerAtShutdownTestCase.test_unregistering_service_worker_when_clearing_data | AssertionError: True is not false
[task 2022-05-06T06:34:24.592Z] 06:34:24     INFO -  Traceback (most recent call last):
[task 2022-05-06T06:34:24.592Z] 06:34:24     INFO -    File "Z:\task_165181252087306\build\venv\lib\site-packages\marionette_harness\marionette_test\testcases.py", line 202, in run
[task 2022-05-06T06:34:24.592Z] 06:34:24     INFO -      testMethod()
[task 2022-05-06T06:34:24.593Z] 06:34:24     INFO -    File "Z:\task_165181252087306\build\tests\marionette\tests\toolkit\components\cleardata\tests\marionette\test_service_worker_at_shutdown.py", line 31, in test_unregistering_service_worker_when_clearing_data
[task 2022-05-06T06:34:24.593Z] 06:34:24     INFO -      self.assertFalse(self.is_service_worker_registered)
[task 2022-05-06T06:34:24.593Z] 06:34:24     INFO -  TEST-INFO took 4128ms
[task 2022-05-06T06:34:24.593Z] 06:34:24     INFO -  1651818864592	Marionette	DEBUG	2 -> [0,15,"Marionette:GetContext",{}]
[task 2022-05-06T06:34:24.593Z] 06:34:24     INFO -  1651818864593	Marionette	DEBUG	2 <- [1,15,null,{"value":"content"}]
[task 2022-05-06T06:34:24.594Z] 06:34:24     INFO -  1651818864594	Marionette	DEBUG	2 -> [0,16,"WebDriver:DeleteSession",{}]
[task 2022-05-06T06:34:24.596Z] 06:34:24     INFO -  1651818864596	Marionette	DEBUG	2 <- [1,16,null,{"value":null}]
[task 2022-05-06T06:34:24.597Z] 06:34:24     INFO -  1651818864597	Marionette	DEBUG	Closed connection 2
[task 2022-05-06T06:34:24.697Z] 06:34:24     INFO -  Application command: Z:\task_165181252087306\build\application\firefox\firefox.exe -no-remote -marionette --wait-for-browser -profile C:\Users\task_165181252087306\AppData\Local\Temp\tmp_856kurk.mozrunner
[task 2022-05-06T06:34:24.947Z] 06:34:24     INFO -  DEBUG: Adding blocker AddonManager: shutting down. for phase profile-before-change
[task 2022-05-06T06:34:24.986Z] 06:34:24     INFO -  DEBUG: Adding blocker IOUtils Blocker (profile-before-change) for phase profile-before-change
[task 2022-05-06T06:34:24.997Z] 06:34:24     INFO -  DEBUG: Adding blocker IOUtils Blocker (xpcom-will-shutdown) for phase xpcom-will-shutdown
[task 2022-05-06T06:34:25.057Z] 06:34:25     INFO -  DEBUG: Adding blocker Flush WebExtension StartupCache for phase IOUtils: waiting for profileBeforeChange IO to complete
[task 2022-05-06T06:34:25.262Z] 06:34:25     INFO -  [2022-05-06T06:34:25Z WARN  rkv::backend::impl_safe::environment] `load_ratio()` is irrelevant for this storage backend.
[task 2022-05-06T06:34:25.345Z] 06:34:25     INFO -  DEBUG: Adding blocker JSON store: writing data for phase AddonManager: Waiting for providers to shut down.
[task 2022-05-06T06:34:25.355Z] 06:34:25     INFO -  DEBUG: Adding blocker Update add-on blocklist state into add-on DB for phase AddonManager: Waiting to start provider shutdown.
[task 2022-05-06T06:34:25.371Z] 06:34:25     INFO -  DEBUG: Adding blocker XPIProvider shutdown for phase quit-application-granted
[task 2022-05-06T06:34:25.373Z] 06:34:25     INFO -  DEBUG: Adding blocker XPIProvider for phase AddonManager: Waiting for providers to shut down.
[task 2022-05-06T06:34:25.374Z] 06:34:25     INFO -  DEBUG: Adding blocker ServiceWorkerRegistrar: Flushing data for phase profile-before-change
[task 2022-05-06T06:34:25.376Z] 06:34:25     INFO -  DEBUG: Adding blocker CrashMonitor: Writing notifications to file after receiving profile-before-change and awaiting all checkpoints written for phase IOUtils: waiting for profileBeforeChange IO to complete
[task 2022-05-06T06:34:25.405Z] 06:34:25     INFO -  DEBUG: Adding blocker TelemetryController: shutting down for phase profile-before-change-telemetry
[task 2022-05-06T06:34:25.453Z] 06:34:25     INFO -  DEBUG: Adding blocker EnvironmentAddonBuilder for phase AddonManager: Waiting to start provider shutdown.
[task 2022-05-06T06:34:25.467Z] 06:34:25     INFO -  DEBUG: Adding blocker RemoteSettingsClient - finish IDB access. for phase profile-before-change
[task 2022-05-06T06:34:25.477Z] 06:34:25     INFO -  1651818865477	Marionette	INFO	Marionette enabled
[task 2022-05-06T06:34:25.588Z] 06:34:25     INFO -  DEBUG: Adding blocker PermissionManager: Flushing data for phase xpcom-will-shutdown
[task 2022-05-06T06:34:25.606Z] 06:34:25     INFO -  1651818865606	Marionette	TRACE	Received observer notification toplevel-window-ready
[task 2022-05-06T06:34:25.618Z] 06:34:25     INFO -  DEBUG: Completed blocker Update add-on blocklist state into add-on DB for phase AddonManager: Waiting to start provider shutdown.
[task 2022-05-06T06:34:25.628Z] 06:34:25     INFO -  DEBUG: Adding blocker ClientManagerService: start destroying IPC actors early for phase xpcom-will-shutdown
[task 2022-05-06T06:34:25.656Z] 06:34:25     INFO -  WARN: driver_utils.cpp:184 (GetVendorString): 	! Unimplemented: GetVendorString(/builds/worker/checkouts/gecko/gfx/angle/checkout/src/libANGLE/renderer/driver_utils.cpp:184)
[task 2022-05-06T06:34:25.663Z] 06:34:25     INFO -  WARN: driver_utils.cpp:184 (GetVendorString): 	! Unimplemented: GetVendorString(/builds/worker/checkouts/gecko/gfx/angle/checkout/src/libANGLE/renderer/driver_utils.cpp:184)
[task 2022-05-06T06:34:25.663Z] 06:34:25     INFO -  [GPU 7588, Renderer] WARNING: Failed to bind API to GL!: file /builds/worker/checkouts/gecko/gfx/gl/GLContextProviderEGL.cpp:622
[task 2022-05-06T06:34:25.664Z] 06:34:25     INFO -  [GPU 7588, Renderer] WARNING: Failed to create GLContext from PBuffer: file /builds/worker/checkouts/gecko/gfx/gl/GLContextProviderEGL.cpp:1159
[task 2022-05-06T06:34:25.664Z] 06:34:25     INFO -  [GPU 7588, Renderer] WARNING: Failed to create EGLContext with khr_rbab_attribs: file /builds/worker/checkouts/gecko/gfx/gl/GLContextProviderEGL.cpp:720
[task 2022-05-06T06:34:25.664Z] 06:34:25     INFO -  Initializing context 07034000 surface 053369E0 on display 0531D000
[task 2022-05-06T06:34:25.665Z] 06:34:25     INFO -  WARN: driver_utils.cpp:184 (GetVendorString): 	! Unimplemented: GetVendorString(/builds/worker/checkouts/gecko/gfx/angle/checkout/src/libANGLE/renderer/driver_utils.cpp:184)
[task 2022-05-06T06:34:25.665Z] 06:34:25     INFO -  WARN: driver_utils.cpp:184 (GetVendorString): 	! Unimplemented: GetVendorString(/builds/worker/checkouts/gecko/gfx/angle/checkout/src/libANGLE/renderer/driver_utils.cpp:184)
[task 2022-05-06T06:34:25.665Z] 06:34:25     INFO -  GL_VENDOR: Google Inc. (Unknown)
[task 2022-05-06T06:34:25.666Z] 06:34:25     INFO -  mVendor: Unknown
[task 2022-05-06T06:34:25.666Z] 06:34:25     INFO -  GL_RENDERER: ANGLE (Unknown, Microsoft Basic Render Driver Direct3D11 vs_5_0 ps_5_0, D3D11-10.0.19041.546)
[task 2022-05-06T06:34:25.666Z] 06:34:25     INFO -  mRenderer: Microsoft Basic Render Driver
[task 2022-05-06T06:34:25.666Z] 06:34:25     INFO -  mIsMesa: 0
[task 2022-05-06T06:34:25.666Z] 06:34:25     INFO -  [GPU 7588, Renderer] WARNING: framebuffer_multisample marked as unsupported: file /builds/worker/checkouts/gecko/gfx/gl/GLContextFeatures.cpp:632
[task 2022-05-06T06:34:25.931Z] 06:34:25     INFO -  DEBUG: Adding blocker MediaShutdownManager: shutdown for phase profile-before-change
[task 2022-05-06T06:34:26.010Z] 06:34:26     INFO -  DEBUG: Adding blocker JSON store: writing data for phase IOUtils: waiting for profileBeforeChange IO to complete
[task 2022-05-06T06:34:26.036Z] 06:34:26     INFO -  DEBUG: Adding blocker Remote Settings profile-before-change for phase profile-before-change
[task 2022-05-06T06:34:26.065Z] 06:34:26     INFO -  DEBUG: Adding blocker ServiceWorkerShutdownBlocker: shutting down Service Workers for phase profile-change-teardown
[task 2022-05-06T06:34:26.076Z] 06:34:26     INFO -  DEBUG: Adding blocker ContentParent: id=1a2cfb00 for phase xpcom-will-shutdown
[task 2022-05-06T06:34:26.076Z] 06:34:26     INFO -  DEBUG: Adding blocker ContentParent: id=1a2cfb00 for phase profile-before-change
[task 2022-05-06T06:34:26.087Z] 06:34:26     INFO -  DEBUG: Adding blocker GMPProvider for phase AddonManager: Waiting for providers to shut down.
[task 2022-05-06T06:34:26.087Z] 06:34:26     INFO -  [Parent 6960, GMPThread] WARNING: Failed to delete GMP storage directory: file /builds/worker/checkouts/gecko/dom/media/gmp/GMPServiceParent.cpp:1754
[task 2022-05-06T06:34:26.178Z] 06:34:26     INFO -  [Child 6920, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/checkouts/gecko/dom/ipc/BrowserChild.cpp:2810
[task 2022-05-06T06:34:26.190Z] 06:34:26     INFO -  [Child 6920, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/checkouts/gecko/dom/ipc/BrowserChild.cpp:2810
[task 2022-05-06T06:34:26.197Z] 06:34:26     INFO -  [Child 6920, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/checkouts/gecko/dom/ipc/BrowserChild.cpp:2810
[task 2022-05-06T06:34:26.204Z] 06:34:26     INFO -  [Child 6920, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/checkouts/gecko/dom/ipc/BrowserChild.cpp:2810
[task 2022-05-06T06:34:26.211Z] 06:34:26     INFO -  [Child 6920, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/checkouts/gecko/dom/ipc/BrowserChild.cpp:2810
[task 2022-05-06T06:34:26.224Z] 06:34:26     INFO -  DEBUG: Adding blocker ContentParent: id=1bc85600 for phase xpcom-will-shutdown
[task 2022-05-06T06:34:26.238Z] 06:34:26     INFO -  DEBUG: Adding blocker ContentParent: id=1bc85600 for phase profile-before-change
[task 2022-05-06T06:34:26.330Z] 06:34:26     INFO -  DEBUG: Adding blocker UrlbarProviderQuickSuggest: Record impression counters reset telemetry for phase profile-change-teardown
[task 2022-05-06T06:34:26.407Z] 06:34:26     INFO -  DEBUG: Adding blocker JSON store: writing data for phase IOUtils: waiting for profileBeforeChange IO to complete
[task 2022-05-06T06:34:26.520Z] 06:34:26     INFO -  [Parent 6960, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/checkouts/gecko/layout/generic/nsFrameSelection.cpp:1601
[task 2022-05-06T06:34:27.094Z] 06:34:27     INFO -  DEBUG: Adding blocker ContentParent: id=17b52a00 for phase xpcom-will-shutdown
[task 2022-05-06T06:34:27.095Z] 06:34:27     INFO -  DEBUG: Adding blocker ContentParent: id=17b52a00 for phase profile-before-change
[task 2022-05-06T06:34:27.124Z] 06:34:27     INFO -  DEBUG: Adding blocker ContentParent: id=1b7ac200 for phase xpcom-will-shutdown
<...>
Flags: needinfo?(hpeuckmann)
Flags: needinfo?(hpeuckmann)
Pushed by hpeuckmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cda9c3f8950b Switch clear cookies and site data checkbox to control sanitization prefs. r=pbz
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Regressions: 1770423
Regressions: 1770290
No longer regressions: 1770290
Regressions: 1771024
No longer regressions: 1770423

Backed out changeset cda9c3f8950b (bug 1681495) on beta for causing bug 1771024 a=backout
https://hg.mozilla.org/releases/mozilla-beta/rev/9399b62c86fb

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 3 years ago2 years ago
Resolution: --- → FIXED
Flags: needinfo?(pbz)
Regressions: 1777419
Regressions: 1777981
Blocks: 1851183
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: