1681691 - Implement ascent-override, descent-override, and line-gap-override

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[Tobi Reif]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 11_0_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36

Steps to reproduce:

It would be very useful if you could implement ascent-override, descent-override, and line-gap-override.
More info:

https://bugs.chromium.org/p/chromium/issues/detail?id=800693
(especially comments #20, #30 and #31)

https://tobireif.com/non_site_stuff/test_case_for_font_position_report_yet_another_font/

https://www.w3.org/TR/css-fonts-4/#font-metrics-override-desc

Comment 1

[Tobi Reif]

Chrome supports it (tested on MacOS vs Windows).

Comment 2

[Florencia Di Ciocco, NI to vbalducci]

Hi,

I've chosen a component for this bug in hope that someone may look at it. We'll await for their answer. If you consider that there's another component that's more proper for this case you may change it.

Regards, Flor.

Comment 3

[Tobi Reif]

Thanks!

Comment 4

[Tobi Reif]

Here's one reason why it's important to implement this feature:

https://tobireif.com/posts/ensuring_the_correct_vertical_position_of_large_text/

(And there's another reason listed in the post below "Another use case".)

Comment 5

[Tobi Reif]

Attachment: the general issue

Given that the issue can be as severe as in the attached screenshot, please consider assigning a high priority to implementing this feature.

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1681691 - Create a NonNegativePercentage type in values:specified. r=#layout-reviewers

Comment 7

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1681691 - Convert the font-stretch descriptor to use NonNegativePercentage. r=#layout-reviewers

Depends on D109285

Comment 8

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1681691 - Add ascent-, descent- and line-gap-override descriptors to the style system. r=#layout-reviewers

Depends on D109286

Comment 9

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1681691 - Add metrics override descriptors to webidl. r=#layout-reviewers

Depends on D109287

Comment 10

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1681691 - Add support for metrics overrides to gfxUserFontEntry, dom::FontFace, etc r=#layout-reviewers

Depends on D109288

Comment 11

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1681691 - Adjust font-family names used in WPT metrics-override tests to avoid spurious failures due to antialiasing in Gecko. r=#layout-reviewers

Depends on D109289

Comment 12

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1681691 - Update metadata for WPT metrics-override tests. r=#layout-reviewers

Depends on D109290

Comment 13

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1681691 - Also remove unnecessary 'unsafe' from a bunch of FontFaceRule descriptor getters. r=#layout-reviewers

Depends on D109287

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4805e23e62d2
Create a NonNegativePercentage type in values:specified. r=emilio
https://hg.mozilla.org/integration/autoland/rev/8d5c2106a2b4
Convert the font-stretch descriptor to use NonNegativePercentage. r=emilio
https://hg.mozilla.org/integration/autoland/rev/12418707741d
Add ascent-, descent- and line-gap-override descriptors to the style system. r=emilio
https://hg.mozilla.org/integration/autoland/rev/e86d980f511e
Also remove unnecessary 'unsafe' from a bunch of FontFaceRule descriptor getters. r=emilio
https://hg.mozilla.org/integration/autoland/rev/af79bc7f7919
Add metrics override descriptors to webidl. r=emilio
https://hg.mozilla.org/integration/autoland/rev/9f9c3c13801a
Add support for metrics overrides to gfxUserFontEntry, dom::FontFace, etc r=emilio
https://hg.mozilla.org/integration/autoland/rev/bb53155c3dd0
Adjust font-family names used in WPT metrics-override tests to avoid spurious failures due to antialiasing in Gecko. r=emilio
https://hg.mozilla.org/integration/autoland/rev/536bbc4b9ecd
Update metadata for WPT metrics-override tests. r=emilio

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28171 for changes under testing/web-platform/tests

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/104675869016
Update manifest expectations for fontface-override-descriptor-getter-setter.sub.html and idlharness.https.html a=manifest-fix

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e43fba82fb31
Update manifest expectations on linux for idlharness.https.html and fontface-override-descriptor-getter-setter.sub.html a=manifest-fix

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 19

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a81bade3ba3a
Backed out 10 changesets for wpt failures on fontface-override-descriptor-getter-setter.sub.html and idlharness.https.html. CLOSED TREE

Comment 20

[Cosmin Sabou [:CosminS]]

Backed out for wpt failures on fontface-override-descriptor-getter-setter.sub.html and idlharness.https.html

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&fromchange=536bbc4b9ecdd209503c9e6966ee285e29df6221&tochange=a81bade3ba3a3873a89a402d5374e8e456cd81f3&searchStr=wpt&test_paths=css%2Fcss-font-loading&selectedTaskRun=Dr_qW_BdS8S94YfSqDffIg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=334003534&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/a81bade3ba3a3873a89a402d5374e8e456cd81f3

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b45b607fee4d
Create a NonNegativePercentage type in values:specified. r=emilio
https://hg.mozilla.org/integration/autoland/rev/d9b488c09c23
Convert the font-stretch descriptor to use NonNegativePercentage. r=emilio
https://hg.mozilla.org/integration/autoland/rev/e7887dc9a3c6
Add ascent-, descent- and line-gap-override descriptors to the style system. r=emilio
https://hg.mozilla.org/integration/autoland/rev/1bc4081f95e4
Also remove unnecessary 'unsafe' from a bunch of FontFaceRule descriptor getters. r=emilio
https://hg.mozilla.org/integration/autoland/rev/5dd06c73f703
Add metrics override descriptors to webidl. r=emilio
https://hg.mozilla.org/integration/autoland/rev/a19844063d00
Add support for metrics overrides to gfxUserFontEntry, dom::FontFace, etc r=emilio
https://hg.mozilla.org/integration/autoland/rev/64edecd0df6f
Adjust font-family names used in WPT metrics-override tests to avoid spurious failures due to antialiasing in Gecko. r=emilio
https://hg.mozilla.org/integration/autoland/rev/dda736a69ceb
Update metadata for WPT metrics-override tests. r=emilio

Comment 22

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failuresin idlharness.https.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/7275678ff756180616f5d550e660d721af304865

Push with failures

Failure log

LE:
Also failed on fontface-override-descriptor-getter-setter.sub.html

Failure log

Comment 23

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 24

[Tobi Reif]

Thanks all for working on this! 🔥🔥🔥🔥🔥

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05c9db2ef078
Create a NonNegativePercentage type in values:specified. r=emilio
https://hg.mozilla.org/integration/autoland/rev/800c1908e363
Convert the font-stretch descriptor to use NonNegativePercentage. r=emilio
https://hg.mozilla.org/integration/autoland/rev/bb712701f65a
Add ascent-, descent- and line-gap-override descriptors to the style system. r=emilio
https://hg.mozilla.org/integration/autoland/rev/3f78a589cfed
Also remove unnecessary 'unsafe' from a bunch of FontFaceRule descriptor getters. r=emilio
https://hg.mozilla.org/integration/autoland/rev/b9aa305826a2
Add metrics override descriptors to webidl. r=emilio
https://hg.mozilla.org/integration/autoland/rev/ba2dad1a5220
Add support for metrics overrides to gfxUserFontEntry, dom::FontFace, etc r=emilio
https://hg.mozilla.org/integration/autoland/rev/cac338430f0d
Adjust font-family names used in WPT metrics-override tests to avoid spurious failures due to antialiasing in Gecko. r=emilio
https://hg.mozilla.org/integration/autoland/rev/1c77bd7b8c3f
Update metadata for WPT metrics-override tests. r=emilio

Comment 27

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/05c9db2ef078
https://hg.mozilla.org/mozilla-central/rev/800c1908e363
https://hg.mozilla.org/mozilla-central/rev/bb712701f65a
https://hg.mozilla.org/mozilla-central/rev/3f78a589cfed
https://hg.mozilla.org/mozilla-central/rev/b9aa305826a2
https://hg.mozilla.org/mozilla-central/rev/ba2dad1a5220
https://hg.mozilla.org/mozilla-central/rev/cac338430f0d
https://hg.mozilla.org/mozilla-central/rev/1c77bd7b8c3f

Comment 28

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 29

[Tobi Reif]

Thanks all!

Comment 30

[Rachel Andrew]

I have written the pages for these descriptors on MDN, updated BCD, added to the release notes.