1681807 - [PiP] PiP keyboard shortcut does not work on MacOS on en-US builds when used with Spanish and some other non-English keyboard layouts

Status: NEW

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Virginia (please send need info request to Brindusa Tot)]

Affected platforms:
MacOS 10.15
Tested on iMac and MacBook devices.

Affected versions:
Nightly 85.0a1
Beta 84.0
ESR 78.5.0esr
Release 83.0

Steps to reproduce:

1- Open Firefox and go to https://www.youtube.com/
2- Pick any video and play it.
3- Press the keyboard shortcut to initiate PiP: (I tried all these combinations)

• Option + Command + Shift + right ]
• Ctrl + Shift + ]
• Ctrl + Shift + }

Expected result:
The PiP window should initiate with the keyboard shortcut.

Actual result:
The PiP window does not initiate with the keyboard shortcut.

Regression-Range:
I will see if there's a regression for this asap.

Severity Suggestion:
I would suggest S2 since this affects all MacOS.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Virginia, could this be similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1665128? I see you filed both, but figured I should ask anyways. Were you able to find if this is a regression?

Comment 2

[Virginia (please send need info request to Brindusa Tot)]

Attachment: keyboard layout.JPG

Hi Jared,

I asked other colleagues to test and some of them weren't able to get it to work, and some did. What we noticed is that the PiP command only works on machines where the standard US keyboard is selected as default. PiP does not work with other international languages, such as Spanish keyboard layout.

I guess it would be low priority but it'd be nice to have PiP keyboard shortcut support for other international languages.

Thanks,
Virginia