1682094 - Checkboxes and radio buttons look disabled/insensitive to user input

Status: NEW

(Toolkit :: Themes, defect, P3)

Description

[Asif Youssuff]

Attachment: image.png

The checkboxes and radios since bug 1678333 landed look grayed out and insensitive to user input. The checked/selected ones look fine, but the inactive ones look like they rely primarily on the dark border and fairly low contrast within the input to signify that they are sensitive to user input.

This is bad because at first glance, it "made me think" about whether I could use those options.

13:56.91 INFO: No more integration revisions, bisection finished.
13:56.91 INFO: Last good revision: 3652d2a382005d6c6755405734168ddeca937ff4
13:56.91 INFO: First bad revision: cc1e3921893e658963369bdae4ab264f56474d5e
13:56.91 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3652d2a382005d6c6755405734168ddeca937ff4&tochange=cc1e3921893e658963369bdae4ab264f56474d5e

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Tim, your patch in bug 1678333 seems to have caused this regression, could you have a look please? Thanks

Comment 2

[Tim Giles [:tgiles]]

I'm not sure how to resolve this bug because the attached screenshot in Comment #0 looks to be correct in regards to the checkboxes section of the Photon design system. If I understand your description correctly Asif, the issue is with the styling of the checkbox that can be interacted with. According to the Photon system, if a checkbox can be interacted with, then its background color is light grey with a slightly more opaque border...which is unfortunate when compared to the previous styling of a completely white background and grey border for the checkbox.

I'm not sure who to bring in that can resolve this issue...Dao, can you provide some assistance?